Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ReadReceiptIndicator a11y improvement #32317

Merged
merged 13 commits into from
May 16, 2024
+93 −32
Merged

feat: ReadReceiptIndicator a11y improvement #32317

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8657259
chore: bump packages
dougfabris Apr 25, 2024
7c34a38
feat: replace icon
dougfabris Apr 25, 2024
f89cd0a
chore: changeset
dougfabris Apr 25, 2024
6b37164
feat: `ReadReceiptIndicator` role
dougfabris Apr 26, 2024
c2119fc
feat: improve `ReadReceiptsModal`
dougfabris Apr 26, 2024
1a91718
chore: e2e tests
dougfabris Apr 26, 2024
4ed6411
typecheck fix
tiagoevanp Apr 26, 2024
b383a6e
chore: change menuitem name
dougfabris Apr 29, 2024
fadb465
Merge remote-tracking branch 'origin/develop' into feat/readReceiptsI…
dougfabris Apr 29, 2024
e236469
fix: e2e test
dougfabris Apr 30, 2024
a74da00
Merge branch 'develop' into feat/readReceiptsIndicator
dougfabris May 10, 2024
a9a7ed6
test: add skip EE only
dougfabris May 16, 2024
9b92de9
Merge branch 'develop' into feat/readReceiptsIndicator
ggazzo May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-berries-guess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': minor
---

Replace the read receipt receipt indicator in order to improve the accessibility complience
2 changes: 1 addition & 1 deletion apps/meteor/client/components/message/ReadReceiptIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type ReadReceiptIndicatorProps = {

const ReadReceiptIndicator = ({ unread }: ReadReceiptIndicatorProps): ReactElement | null => (
<Box position='absolute' insetBlockStart={2} insetInlineEnd={8}>
<Icon name='check' size='x16' color={unread ? 'annotation' : 'info'} />
<Icon size='x16' name={unread ? 'check' : 'double-check'} color={unread ? 'annotation' : 'info'} />
</Box>
);

Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/ee/server/services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"ws": "^8.8.1"
},
"devDependencies": {
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@types/cookie": "^0.5.3",
"@types/cookie-parser": "^1.4.5",
"@types/ejson": "^2.2.1",
Expand Down
4 changes: 2 additions & 2 deletions apps/meteor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,15 +242,15 @@
"@rocket.chat/favicon": "workspace:^",
"@rocket.chat/forked-matrix-appservice-bridge": "^4.0.2",
"@rocket.chat/forked-matrix-bot-sdk": "^0.6.0-beta.3",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-hooks": "^0.33.1",
"@rocket.chat/fuselage-polyfills": "~0.31.25",
"@rocket.chat/fuselage-toastbar": "^0.31.26",
"@rocket.chat/fuselage-tokens": "^0.33.1",
"@rocket.chat/fuselage-ui-kit": "workspace:^",
"@rocket.chat/gazzodown": "workspace:^",
"@rocket.chat/i18n": "workspace:^",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/instance-status": "workspace:^",
"@rocket.chat/jwt": "workspace:^",
"@rocket.chat/layout": "~0.31.26",
Expand Down
4 changes: 2 additions & 2 deletions ee/packages/ui-theming/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"private": true,
"devDependencies": {
"@rocket.chat/css-in-js": "~0.31.25",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-hooks": "^0.33.1",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/ui-contexts": "workspace:~",
"@storybook/addon-actions": "~6.5.16",
"@storybook/addon-docs": "~6.5.16",
Expand Down
2 changes: 1 addition & 1 deletion packages/core-services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"dependencies": {
"@rocket.chat/apps-engine": "^1.42.1",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/message-parser": "workspace:^",
"@rocket.chat/models": "workspace:^",
"@rocket.chat/rest-typings": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion packages/core-typings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
],
"dependencies": {
"@rocket.chat/apps-engine": "^1.42.1",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/message-parser": "workspace:^",
"@rocket.chat/ui-kit": "workspace:~"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/fuselage-ui-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@
"@babel/preset-typescript": "~7.22.15",
"@rocket.chat/apps-engine": "^1.42.1",
"@rocket.chat/eslint-config": "workspace:^",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-hooks": "^0.33.1",
"@rocket.chat/fuselage-polyfills": "~0.31.25",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/prettier-config": "~0.31.25",
"@rocket.chat/styled": "~0.31.25",
"@rocket.chat/ui-avatar": "workspace:^",
Expand Down
2 changes: 1 addition & 1 deletion packages/gazzodown/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"@babel/core": "~7.22.20",
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/css-in-js": "~0.31.25",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-tokens": "^0.33.1",
"@rocket.chat/message-parser": "workspace:^",
"@rocket.chat/styled": "~0.31.25",
Expand Down
1 change: 0 additions & 1 deletion packages/i18n/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"/dist"
],
"type": "module",

"volta": {
"extends": "../../package.json"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"devDependencies": {
"@babel/core": "~7.22.20",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/ui-contexts": "workspace:^",
"@types/babel__core": "~7.20.3",
"@types/react": "~17.0.69",
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"@babel/core": "~7.22.20",
"@react-aria/toolbar": "^3.0.0-beta.1",
"@rocket.chat/css-in-js": "~0.31.25",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-hooks": "^0.33.1",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/mock-providers": "workspace:^",
"@rocket.chat/ui-contexts": "workspace:~",
"@storybook/addon-actions": "~6.5.16",
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-composer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"@babel/core": "~7.22.20",
"@react-aria/toolbar": "^3.0.0-beta.1",
"@rocket.chat/eslint-config": "workspace:^",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/icons": "^0.35.0",
"@storybook/addon-actions": "~6.5.16",
"@storybook/addon-docs": "~6.5.16",
"@storybook/addon-essentials": "~6.5.16",
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-video-conf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"@babel/core": "~7.22.20",
"@rocket.chat/css-in-js": "~0.31.25",
"@rocket.chat/eslint-config": "workspace:^",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-hooks": "^0.33.1",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/styled": "~0.31.25",
"@rocket.chat/ui-avatar": "workspace:^",
"@rocket.chat/ui-contexts": "workspace:^",
Expand Down
4 changes: 2 additions & 2 deletions packages/uikit-playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
"@codemirror/tooltip": "^0.19.16",
"@lezer/highlight": "^1.1.6",
"@rocket.chat/css-in-js": "~0.31.25",
"@rocket.chat/fuselage": "^0.53.4",
"@rocket.chat/fuselage": "^0.53.5",
"@rocket.chat/fuselage-hooks": "^0.33.1",
"@rocket.chat/fuselage-polyfills": "~0.31.25",
"@rocket.chat/fuselage-toastbar": "^0.31.26",
"@rocket.chat/fuselage-tokens": "^0.33.1",
"@rocket.chat/fuselage-ui-kit": "workspace:~",
"@rocket.chat/icons": "^0.34.0",
"@rocket.chat/icons": "^0.35.0",
"@rocket.chat/logo": "^0.31.30",
"@rocket.chat/styled": "~0.31.25",
"@rocket.chat/ui-avatar": "workspace:^",
Expand Down