Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UsersInRole not displaying all available rooms for admin #32320

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 26, 2024

Proposed changes (including videos or screenshots)

  • ask missing endpoint documentation

Issue(s)

Closes #23437
Closes #21639

Steps to test or reproduce

Further comments

CORE-393

Copy link
Contributor

dionisio-bot bot commented Apr 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: 81611f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title fix: Users in role page not displaying all available rooms for admin fix: UsersInRole not displaying all available rooms for admin Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.83%. Comparing base (3433f48) to head (81611f7).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32320      +/-   ##
===========================================
+ Coverage    55.58%   55.83%   +0.25%     
===========================================
  Files         2405     2427      +22     
  Lines        52929    53300     +371     
  Branches     10872    10946      +74     
===========================================
+ Hits         29421    29762     +341     
- Misses       20907    20915       +8     
- Partials      2601     2623      +22     
Flag Coverage Δ
e2e 55.01% <90.90%> (+0.06%) ⬆️
e2e-api 41.10% <ø> (+1.00%) ⬆️
unit 73.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.9 milestone Apr 26, 2024
@dougfabris dougfabris marked this pull request as ready for review May 10, 2024 18:14
@dougfabris dougfabris requested a review from a team as a code owner May 10, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant