New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Users in role table not rendering the empty state properly #32412
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3b06b2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32412 +/- ##
===========================================
- Coverage 56.22% 56.00% -0.22%
===========================================
Files 2425 2424 -1
Lines 53522 53467 -55
Branches 11024 11019 -5
===========================================
- Hits 30093 29945 -148
- Misses 20806 20883 +77
- Partials 2623 2639 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add tests to cover the problems mentioned in the PR description? Create tests throwing error and the empty state, and make sure it shows the toast...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already created a test to check if its rendering the empty state on should remove user1 as moderator of target channel
. It shouldn't show the toast, its annoying.
About the error state: I'm not sure how simulate it during the e2e test since its the prevention state (fallback), it renders when something get wrong on the request.
Proposed changes (including videos or screenshots)
Depends on: #32320
It renders the error and empty state on the table instead of a wrong toast message when not finding users in role.
Also adds the proper fields validation
Issue(s)
Steps to test or reproduce
Further comments
CORE-465