fix: Translations falling back to english after refreshing the page #32348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 7f382f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32348 +/- ##
===========================================
+ Coverage 55.53% 55.58% +0.05%
===========================================
Files 2401 2403 +2
Lines 52855 52866 +11
Branches 10854 10857 +3
===========================================
+ Hits 29353 29387 +34
+ Misses 20898 20879 -19
+ Partials 2604 2600 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
previously approved these changes
Apr 30, 2024
MarcosSpessatto
requested changes
Apr 30, 2024
…/i18n * 'fix/i18n' of github.com:RocketChat/Rocket.Chat: Create fresh-students-remember.md
MarcosSpessatto
requested changes
May 2, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
May 8, 2024
dougfabris
approved these changes
May 8, 2024
dougfabris
removed
the
stat: ready to merge
ggazzo
approved these changes
May 8, 2024
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
added a commit
that referenced
this pull request
May 8, 2024
…32348) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Merged
|
/backport 6.6.8 |
1 similar comment
|
/backport 6.6.8 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
|
/backport 6.7.3 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
gabriellsh
added a commit
that referenced
this pull request
May 15, 2024
…32348) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
gabriellsh
added a commit
that referenced
this pull request
May 15, 2024
…32348) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
|
/backport 6.6.8 |
|
Pull request #32441 added to Project: "Patch 6.6.8" |
|
/backport 6.7.3 |
|
Pull request #32442 added to Project: "Patch 6.7.3" |
dionisio-bot bot
pushed a commit
that referenced
this pull request
May 15, 2024
…32348) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
ggazzo
added a commit
that referenced
this pull request
May 20, 2024
…32348) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
i18next instance was being initialized twice, making it so that the resources object would be overwritten with only the fallback language which is loaded by default.
Issue(s)
Closes #32268
Closes #31802
CORE-295
Steps to test or reproduce
Further comments