-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on teams endpoints #32351
Conversation
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32351 +/- ##
=================================================
- Coverage 55.74% 55.52% -0.23%
=================================================
Files 2409 2406 -3
Lines 52936 52871 -65
Branches 10875 10860 -15
=================================================
- Hits 29511 29356 -155
- Misses 20812 20905 +93
+ Partials 2613 2610 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
teams
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-348
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.