New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow #32398
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1df6f70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32398 +/- ##
===========================================
- Coverage 55.86% 55.86% -0.01%
===========================================
Files 2432 2432
Lines 53480 53480
Branches 10993 10993
===========================================
- Hits 29877 29874 -3
- Misses 20965 20966 +1
- Partials 2638 2640 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it on behalf of frontend team!
a2feeaa
Proposed changes (including videos or screenshots)
Accounts_AllowPasswordChangeForOAuthUsers
in theusers.forgotPassword
endpoint.Issue(s)
Steps to test or reproduce
Current behavior: the reset password e-mail is sent (even to LDAP/OAuth users that didn't have a password before);
Expected behavior: the reset password e-mail should not be sent.
Further comments
CORE-439