Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Users tab misaligned #32451

Merged
merged 1 commit into from
May 17, 2024
Merged

regression: Users tab misaligned #32451

merged 1 commit into from
May 17, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented May 17, 2024

Proposed changes (including videos or screenshots)

before

Screenshot 2024-05-17 at 11 29 33

after

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: 9a20dec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.9 milestone May 17, 2024
@dougfabris dougfabris marked this pull request as ready for review May 17, 2024 14:30
@dougfabris dougfabris requested a review from a team as a code owner May 17, 2024 14:30
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.84%. Comparing base (c29c69e) to head (9a20dec).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32451   +/-   ##
========================================
  Coverage    55.84%   55.84%           
========================================
  Files         2432     2431    -1     
  Lines        53478    53447   -31     
  Branches     10992    10986    -6     
========================================
- Hits         29864    29850   -14     
+ Misses       20975    20961   -14     
+ Partials      2639     2636    -3     
Flag Coverage Δ
e2e 55.17% <100.00%> (-0.02%) ⬇️
unit 72.75% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 17, 2024
@kodiakhq kodiakhq bot merged commit c722d3e into develop May 17, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the reg/usersTab branch May 17, 2024 18:58
gabriellsh added a commit that referenced this pull request May 28, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits)
  refactor: IntegrationHistory out of DB Watcher (#32502)
  fix: Message update being broadcasted without updated values (#32472)
  test: make api teams test fully independent (#31756)
  test: Fix test name (#32490)
  fix: streams being called with no logged user (#32489)
  feat: Un-encrypted messages not allowed in E2EE rooms (#32040)
  feat(UiKit): Users select (#31455)
  fix: Re-login same browser tab issues (#32479)
  chore: move all webclient code out of the COSS folders (#32273)
  chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619)
  fix: Don't show join default channels option for edit user form  (#31750)
  fix: CAS user merge not working (#32444)
  fix: Overriding Retention Policy not working (#32454)
  fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364)
  fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398)
  fix: Bypass trash when removing OTR system messages and read receipts (#32269)
  fix: Monitors dissapearing from Unit upon edit (#32393)
  fix: Link image preview not opening in gallery (#32391)
  feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439)
  regression: Users tab misaligned (#32451)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants