fix(Omnichannel): Contact Center sort by date #32566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1ebc017 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32566 +/- ##
===========================================
- Coverage 56.52% 55.06% -1.47%
===========================================
Files 2484 2397 -87
Lines 54691 53207 -1484
Branches 11287 10946 -341
===========================================
- Hits 30916 29298 -1618
- Misses 21126 21319 +193
+ Partials 2649 2590 -59
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
changed the title
MarcosSpessatto
requested changes
Jun 11, 2024
…ketChat/Rocket.Chat into fix/omnichannel-contact-sort-by-date
|
About the UI test: It's very expensive to create another test than the API integration one and there is no necessity of testing in the UI the same thing was tested from integration (if the API result is right). The fix here is not in the UI, but the API not receiving the right query string parameters. |
tiagoevanp
commented
Jun 14, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MarcosSpessatto
approved these changes
Jun 18, 2024
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fix the sorting by last chat in Contact Center table.
Issue(s)
Steps to test or reproduce
Further comments
SUP-578