Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable db watchers on local envs #32589

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Since this will be the new default moving any time soon, it is a good idea to have it configured like this during development, so issues can be easily found during that phase.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: 70a2fc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego added this to the 6.10 milestone Jun 11, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.43%. Comparing base (16b67aa) to head (70a2fc2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32589      +/-   ##
===========================================
+ Coverage    56.41%   56.43%   +0.02%     
===========================================
  Files         2445     2450       +5     
  Lines        53923    54017      +94     
  Branches     11116    11134      +18     
===========================================
+ Hits         30418    30482      +64     
+ Misses       20883    20880       -3     
- Partials      2622     2655      +33     
Flag Coverage Δ
e2e 56.23% <ø> (+0.04%) ⬆️
unit 71.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Jun 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 12, 2024
@kodiakhq kodiakhq bot merged commit 99de6d2 into develop Jun 12, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the chore-disable-watchers-local branch June 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants