Convert Spotify Package to JS #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Mar 23, 2017
| Template.registerHelper('match', (source, regex) => new RegExp(regex).test(source)); | ||
|
|
||
| Template.oembedBaseWidget.onCreated(function() { | ||
| if (this.data && (this.data.meta && /(music.song|music.album)/.test(this.data.meta.ogType)) && this.data.parsedUrl && this.data.parsedUrl.host === 'open.spotify.com') { |
There was a problem hiding this comment.
The correct regex should be /^(music\.song|music\.album)$/
There was a problem hiding this comment.
Or you can use ['music.song', 'music.album'].includes(this.data.meta.ogType)
| // Verify if this part is code | ||
| const part = msgParts[index]; | ||
| let item; | ||
| if (((part != null ? part.length : undefined) != null) > 0) { |
There was a problem hiding this comment.
That comparison will not work, will be true > 0 or false > 0
| let item; | ||
| if (((part != null ? part.length : undefined) != null) > 0) { | ||
| const codeMatch = part.match(/(?:```(\w*)[\n ]?([\s\S]*?)```+?)|(?:`(?:[^`]+)`)/); | ||
| if ((codeMatch == null)) { |
| const msgParts = source.split(/(```\w*[\n ]?[\s\S]*?```+?)|(`(?:[^`]+)`)/); | ||
|
|
||
| return (() => { | ||
| const result = []; |
There was a problem hiding this comment.
You can remote this return and result.
Coffee always return the last line, but we are not using the return of this method here
|
|
||
| process(message, message.msg, function(message, msgParts, index, part) { | ||
| const re = /(?:^|\s)spotify:([^:\s]+):([^:\s]+)(?::([^:\s]+))?(?::(\S+))?(?:\s|$)/g; | ||
| return (() => { |
| let process = undefined; | ||
| class Spotify { | ||
| static initClass() { | ||
| process = function(message, source, callback) { |
There was a problem hiding this comment.
You can move this process to outside the classe
rodrigok
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core