Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted rocketchat-lib 3 #6672

Merged
merged 9 commits into from
Apr 28, 2017
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 12, 2017

merge #6593 first

@@ -0,0 +1,102 @@
/* globals fireGlobalEvent readMessage*/
const openRoom = function(type, name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove the global var currentTracker

return _(actions).reduceRight(_.wrap, (err, success) => callback(err, success))();
},
load(key, value, initialLoad) {
Object.keys({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use a simple array?

}
});

if (room && !room.t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If room is undefined the code will continue and 3 lines below the assign from room.t will thrown an exception

t: 1
}
});
if (room && !room.t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@rodrigok rodrigok merged commit 58c2e46 into RocketChat:develop Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants