Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Search users also by email in toolbar #7334

Merged
merged 1 commit into from
Jul 25, 2017
Merged

[NEW] Search users also by email in toolbar #7334

merged 1 commit into from
Jul 25, 2017

Conversation

shahar3012
Copy link
Contributor

@RocketChat/core

Closes #7333

Changes

  • Changed findByActiveUsersExcept query to allow to search users also by email (emails.address) in toolbar

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@karlprieb karlprieb requested a review from ggazzo June 25, 2017 13:09
@shahar3012
Copy link
Contributor Author

@karlprieb @ggazzo, is someone reviewing this?
I hope we can get it into Rocket.Chat next version.

@ggazzo
Copy link
Member

ggazzo commented Jul 24, 2017

hey @shahar3012 sorry for delay, I just think we should show the email in some place...but this problem already exists for name/username

@rodrigok rodrigok added this to the 0.58.0 milestone Jul 25, 2017
@rodrigok rodrigok merged commit 923c1b0 into RocketChat:develop Jul 25, 2017
@goiaba goiaba mentioned this pull request Jul 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.58.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shahar3012 @CLAassistant @ggazzo @rodrigok