Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] flex-tab now is side by side with message list #7448

Merged
merged 9 commits into from
Jul 13, 2017
Merged

[NEW] flex-tab now is side by side with message list #7448

merged 9 commits into from
Jul 13, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 7, 2017 •
edited by rodrigok
Loading

@RocketChat/core

Closes #7434

@ggazzo ggazzo requested a review from karlprieb July 7, 2017 19:16
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7448 July 7, 2017 19:16 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7448 July 7, 2017 19:32 Inactive
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7448 July 7, 2017 19:49 Inactive
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@RocketChat RocketChat deleted a comment Jul 7, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7448 July 7, 2017 20:38 Inactive
MartinSchoeler
MartinSchoeler previously requested changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to fix the problem with the flex-tab scroll area not going until the end of the tab

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7448 July 12, 2017 20:45 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7448 July 12, 2017 21:00 Inactive
@rodrigok rodrigok merged commit 475ed0a into develop Jul 13, 2017
@rodrigok rodrigok deleted the flex-tab branch July 13, 2017 13:54
@rodrigok rodrigok mentioned this pull request Jul 13, 2017
Closed
@sampaiodiego sampaiodiego mentioned this pull request Jul 13, 2017
Merged
@MartinSchoeler MartinSchoeler mentioned this pull request Jul 19, 2017
Closed
@engelgabriel engelgabriel modified the milestone: 0.58.0 Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

@MartinSchoeler MartinSchoeler MartinSchoeler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.58.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ggazzo @karlprieb @MartinSchoeler @rodrigok @engelgabriel