Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Adds admin option to globally set mobile devices to always be notified regardless of presence status. #7641

Merged
merged 6 commits into from
Dec 7, 2017

Conversation

stalley
Copy link
Contributor

@stalley stalley commented Aug 2, 2017

@RocketChat/core

Closes #1602

image

Adds an option to always send push to mobile devices regardless of Online or Away presence status. Defaults to false. This is a global option in Admin->General->Notifications.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2017

CLA assistant check
All committers have signed the CLA.

@stalley
Copy link
Contributor Author

stalley commented Aug 15, 2017

@rodrigok Can this be reviewed if it's an acceptable addition.

@stalley
Copy link
Contributor Author

stalley commented Aug 19, 2017

@engelgabriel Can this be reviewed? I've done 10 deployments of Rocket Chat servers so far and every single one has asked for this to be an option.

@davidrea
Copy link

👍 Adding my vote to please review and merge this PR!

Suggest maybe adding an extra set of parens around the 1st two conditionals at (new) line 237. But then, I'm an embedded C guy who starts to twitch when order-of-operations is left up to the compiler! 😉

@rodrigok
Copy link
Member

Hi @stalley I liked the idea, can you fix the conflict? I'll add this PR to the version 0.60

@rodrigok rodrigok added this to the 0.60.0 milestone Sep 12, 2017
@stalley
Copy link
Contributor Author

stalley commented Sep 15, 2017

@rodrigok I'll get that resolved this weekend.

@stalley
Copy link
Contributor Author

stalley commented Sep 28, 2017

@rodrigok Apologies, I'm getting this cleaned up

@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@RocketChat RocketChat deleted a comment Sep 28, 2017
@stalley
Copy link
Contributor Author

stalley commented Sep 28, 2017

@rodrigok Everything looks good now.

@stalley
Copy link
Contributor Author

stalley commented Sep 29, 2017

@rodrigok Wanted to be sure this made it in for 0.60 Thanks!

@stalley
Copy link
Contributor Author

stalley commented Oct 4, 2017

@rodrigok @sampaiodiego Sorry to keep spamming this, just don't want this to get left behind.

@engelgabriel
Copy link
Member

This will be merged into 0.60.0 we are just too busy with the UX issues of the 0.59.0

@stalley
Copy link
Contributor Author

stalley commented Oct 19, 2017

@engelgabriel Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Push Notification logic
5 participants