[NEW] Template to show Custom Fields in user info view #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows admin user to choose extra fields to be shown in the user's info tab.
The templateVarHandler method was created by extracting from the getDataToSyncUserData method the code that handles the template var substitution. This commit makes use of the extracted method aiming to not duplicate code.
|
Amazing, I love this |
rodrigok
approved these changes
Aug 23, 2017
rodrigok
changed the title
|
Может кто подскажет как это сделать простому смертному? |
|
The custom fields do not display for me |
|
It's broken since I upgraded to 0.61.1. Customs fields are displayed in My account > Profile but not in the userinfo tab. No log to help debugging... |
|
@magicbelette There’s already a PR to fix that issue #9821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7610
This change allows admin user to choose extra fields to be shown in the user's info tab. A new field was introduced (Accounts):
Below is a screenshot of the UserInfo tab:
Besides that, as the template var handling logic was extracted to a method, I changed the
getDataToSyncUserDatamethod to use it.