Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Custom fields not showing on user info panel #9821

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 21, 2018

@RocketChat/core
@juliagrala

before:
image

after:
image

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Feb 21, 2018

I closed my PR in favor of this one, because your solution looks a bit smoother :)
#9646

@rodrigok rodrigok changed the title [FIX] small fix to show custom fields on userinfo Fix: Custom fields not showing on user info panel Feb 21, 2018
@rodrigok rodrigok merged commit e49fdaf into develop Feb 21, 2018
0.62.0 automation moved this from Desirable to Done Feb 21, 2018
@rodrigok rodrigok deleted the hotfix-customfields branch February 21, 2018 22:24
@JSzaszvari
Copy link
Contributor

@ggazzo can you post what exactly you have in your "Accounts -> Custom Fields to Show in User Info" & "LDAP -> User Data Field Map" sections to make this work please?

Even after testing this PR i'm unable to get any custom fields to display

@kaiiiiiiiii
Copy link
Contributor

@JSzaszvari I've posted an explanation how the custom fields configuration should work in an issue the other day. You may want to have a look:
#9763 (comment)

@JSzaszvari
Copy link
Contributor

@kaiiiiiiiii Thank you very much, thats amazing. Now I've got them showing up. Just need to work out how to populate the fields from AD/LDAP now. Have you tried this?

@geekgonecrazy
Copy link
Contributor

@kaiiiiiiiii Would you mind creating a PR in our documentation for this? I can imagine it'd help a lot of others out as well. 👍

@JSzaszvari
Copy link
Contributor

I was just about to suggest the same thing. @kaiiiiiiiii Happy to do this if you'd like otherwise i'll leave the honors with you.

@JSzaszvari
Copy link
Contributor

@kaiiiiiiiii Actually, looks like i just figred it out. THanks for your help in the message above. Invaluable advice.

If you want to submit a PR for that side, I can do the Populating from LDAP side?

@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Feb 22, 2018

I can do that, no worries :) And for sure mate, I’ll tag you in my docs PR so you can commit your LDAP part.

@ggazzo
Copy link
Member Author

ggazzo commented Feb 22, 2018

@kaiiiiiiiii I didnt see or solution before, sorry about that, but the most important its working now ;)

@ggazzo
Copy link
Member Author

ggazzo commented Feb 22, 2018

@JSzaszvari

[{ label : key }...]
image

@suvarov
Copy link

suvarov commented Feb 24, 2018

Hey guys!

I was wondering if this works in 0.61.0.
Tried to add simple custom field in Accounts -> Custom Fields section:
{ "department": {   "type": "text",   "required": true,   "minLength": 2,   "maxLength": 10  } }
and added "department" in Accounts -> Custom Fields to Show in User Info
but nothing happens when I review user profiles including my own.

any advice in what direction I should look for the answer?

@kaiiiiiiiii
Copy link
Contributor

@suvarov Customer user fields do not work in 0.61.x, but it will be fixed in 0.62.0.

@suvarov
Copy link

suvarov commented Feb 24, 2018

@kaiiiiiiiii thnx!

@rodrigok rodrigok mentioned this pull request Feb 28, 2018
@piotrkochan
Copy link
Contributor

@kaiiiiiiiii this does not work for me on 0.69.1. Users does not have these options visible in profile-edit page as in profiles itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.62.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

8 participants