-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Direct Messages Between Multiple Users #9106
Conversation
Interesting, can we see some screenshots of this in action? |
Screenshots added. |
Quick question: right now, I can't create a channel because I'm not an administrator. In this new feature, will I be able to create a multiple-person chat, even though I won't be able to create a channel? |
@cranau You should be able to do so after the last commit. However admin can disable multi-person chats creation via separate setting. |
@gnidorah Awesome! Thank you for your work on this. By the way, the chat that I'm using is chat.thebitcoincash.fund in case you want to test the environment where I ran into the issue. |
@graywolf336 @rodrigok Could someone finally review this? Thanks. |
@gnidorah mind me asking, but what's the difference between this and |
@jgtoriginal Please look at #4489
Conrete differences:
|
@gnidorah this is an awesome feature then!! Actually I've been asked couple of times if such a feature existed, in a scenario where a specific user would like to introduce person Channels and groups are tightly coupled to permissions and ownership, so I believe this kind of |
When can we expect this to be merged ? We are currently waiting on this to completly switch from Slack. |
@engelgabriel Any news on this PR? |
When will is the PR going to be merged? Waiting for this feature to switch from slack to rocketchat. |
Unfortunately for us, my boss has pulled the plug on the Rocket.Chat experiment, with this PR being outstanding being one of the main reasons. I wish you guys all the best :) |
How are we looking here? Can we get an update? @ggazzo @engelgabriel |
Sorry Rocket.Chat but this is ridiculous. You say send your PRs and then they get left here rotting, and then people leave. That is just a completely insane waste of work and really bad publicity. This is how you lose confidence in your community, and then you'll be wondering why no one contributes any more code. Yes, there may be valid reasons why it isn't appropriate to merge right now. But at least give a contributor the courtesy of a response. Ignoring them does you no favours at all. |
sorry @EveBC and @reetp , actually I already "reviewed" the PR and the feature is a little bit far from what you are expecting comparing with slack. This quarter we are a little bit busy fixing and improving features we already have. I'm afraid we already defined which new "features" we gonna be releasing until the end of the year.
But I swear to you, Direct Messages is your feature priority number one for the next quarter, probably until the end of January. Really sorry about the delay... |
Guys you set the release version to 2.0.0. Now 2.4.1 is released, but we're still waiting for it! This is a primary feature, which could be used in any other team collaboration tool. So, in my opinion it would be the best to set all focus on this and only fix security issues before. In any other case this good software will lose more customers! |
We lost our patience after waiting over 2 years for this fundamental function, we stay on Slack. Our tests 2 years ago was something like below:
After 2 years... nothing changed. Rocket Chat gained some bells and whistles instead. |
@ggazzo @engelgabriel This should really be taken care off.... :-/ |
@engelgabriel what is the hold up on merging this? seriously guys, this is not a great look. |
This is really ridiculous. Not putting in such a basic feature. When can we expect the merge? |
This PR is planned for this quarter, it will take some time since it will require many changes. It's not only about merge it, we need to take care of the performance, security and usability of this feature to deliver something good. |
Yay! A new major version, finally we could use ... wait what? This essential feature is still not in Rocket.Chat? What is the timetable of this? You said "this quarter". The quarter will end at the 31.03.2020, ok let's say we include the whole week, so it is the 05.04.2020. With a little bit goodwill, there are 7 weeks from now. When you will start with the implementation? When you want to finish the work? When the release will come out to use it? What if you do need another major release (SemVer), should be wait for another 5-6 month? |
@ChrissW-R1 as I told before, we had a feature list to delivery:
ok, maybe took more time than we expected to finish some of them, but all the features we promised are here, and you can always check the releases notes if you have some doubt about what we have done... thanks for your concerns about our internal "deadline" and how much effort we gonna spend developing this feature... but until now we are still following the plan. |
closed (and implemented) by #16761 ... thank you for all the effort you put on this. |
Hey everybody. I want to thank all contributors for their work! This is a great feature. Please be aware of the fact that there are people really appreciating your contribution for Rocket.Chat! |
Thanks @GoetheG Comments like yours (actually on both sides) are greatly appreciated by the team and community. |
I hope you enjoy the feature, we made a few decisions based on how your DMs works, but we are opened to suggestions :) |
@ggazzo Here is a suggestion - RocketChat/feature-requests#323 |
@RocketChat/core
Closes #4489
Creation
![screenshot_20171225_154426](https://user-images.githubusercontent.com/12064730/34339903-b7f179e2-e98b-11e7-88f0-e97607a913a0.png)
![screenshot_20171226_160104](https://user-images.githubusercontent.com/12064730/34357224-440c7c36-ea56-11e7-897e-53f04e02c260.png)
![screenshot_20171226_160223](https://user-images.githubusercontent.com/12064730/34357226-480a4570-ea56-11e7-8bd3-991b7853654d.png)
![screenshot_20171225_154644](https://user-images.githubusercontent.com/12064730/34339905-bba463ba-e98b-11e7-9c70-77877d198fdd.png)
![screenshot_20171225_154956](https://user-images.githubusercontent.com/12064730/34339907-bef61dec-e98b-11e7-844f-08e101cc18b6.png)
Inviting
Convertion