Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Direct Messages Between Multiple Users #9106

Closed
wants to merge 113 commits into from
Closed

[NEW] Direct Messages Between Multiple Users #9106

wants to merge 113 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2017

@RocketChat/core

Closes #4489

Creation
screenshot_20171225_154426
Inviting
screenshot_20171226_160104
screenshot_20171226_160223
Convertion
screenshot_20171225_154644
screenshot_20171225_154956

@RocketChat RocketChat deleted a comment Dec 13, 2017
@RocketChat RocketChat deleted a comment Dec 13, 2017
@graywolf336
Copy link
Contributor

Interesting, can we see some screenshots of this in action?

@ghost ghost changed the title Direct Messages Between Multiple Users [NEW] Direct Messages Between Multiple Users Dec 14, 2017
@ghost
Copy link
Author

ghost commented Dec 14, 2017

Screenshots added.
Rebased, as #9117 doesn't blocks this PR if better usernames are used for testing.

@cranau
Copy link

cranau commented Dec 16, 2017

Quick question: right now, I can't create a channel because I'm not an administrator. In this new feature, will I be able to create a multiple-person chat, even though I won't be able to create a channel?

@ghost
Copy link
Author

ghost commented Dec 22, 2017

@cranau You should be able to do so after the last commit. However admin can disable multi-person chats creation via separate setting.

@ghost ghost mentioned this pull request Dec 22, 2017
@cranau
Copy link

cranau commented Dec 24, 2017

@gnidorah Awesome! Thank you for your work on this. By the way, the chat that I'm using is chat.thebitcoincash.fund in case you want to test the environment where I ran into the issue.

@ghost
Copy link
Author

ghost commented Jan 9, 2018

@graywolf336 @rodrigok Could someone finally review this? Thanks.

@jgtoriginal
Copy link
Contributor

@gnidorah mind me asking, but what's the difference between this and private groups ?

@ghost
Copy link
Author

ghost commented Jan 22, 2018

@jgtoriginal Please look at #4489

Setting up a new private group is painful. Slack allows you to quickly add users together without naming the group but simply inviting users into a message together and then as those group messages aren't used they are moved down the most recent messages in direct messages.

Conrete differences:

  • You don't set the group name (instead group members are listed)
  • History is cleared if you convert this to a channel
  • Admin can set different permissions for this

@jgtoriginal
Copy link
Contributor

@gnidorah this is an awesome feature then!! Actually I've been asked couple of times if such a feature existed, in a scenario where a specific user would like to introduce person A to person B via rocket chat by creating a channel between both, do the introduction and then leave that specific channel.

Channels and groups are tightly coupled to permissions and ownership, so I believe this kind of MDM (multi direction message) would be a must have feature for RC.

@RocketChat RocketChat deleted a comment Feb 2, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9106 February 15, 2018 14:49 Inactive
@MLefebvreICO
Copy link

When can we expect this to be merged ?

We are currently waiting on this to completly switch from Slack.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9106 March 3, 2018 07:13 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9106 March 3, 2018 07:18 Inactive
@ghost
Copy link
Author

ghost commented Mar 12, 2018

@engelgabriel Any news on this PR?

@JesseVS
Copy link

JesseVS commented Mar 23, 2018

When will is the PR going to be merged? Waiting for this feature to switch from slack to rocketchat.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9106 March 25, 2018 12:30 Inactive
@engelgabriel engelgabriel modified the milestones: 2.1.0, 2.2.0 Oct 13, 2019
@ggazzo ggazzo modified the milestones: 2.2.0, 2.3.0 Oct 18, 2019
@ChristineBoersen
Copy link

Unfortunately for us, my boss has pulled the plug on the Rocket.Chat experiment, with this PR being outstanding being one of the main reasons.

I wish you guys all the best :)

@EveBC
Copy link

EveBC commented Nov 22, 2019

How are we looking here? Can we get an update? @ggazzo @engelgabriel

@reetp
Copy link

reetp commented Nov 22, 2019

Unfortunately for us, my boss has pulled the plug on the Rocket.Chat experiment, with this PR being outstanding being one of the main reasons.

Sorry Rocket.Chat but this is ridiculous.

You say send your PRs and then they get left here rotting, and then people leave.

That is just a completely insane waste of work and really bad publicity. This is how you lose confidence in your community, and then you'll be wondering why no one contributes any more code.

Yes, there may be valid reasons why it isn't appropriate to merge right now. But at least give a contributor the courtesy of a response.

Ignoring them does you no favours at all.

@ggazzo
Copy link
Member

ggazzo commented Nov 23, 2019

sorry @EveBC and @reetp , actually I already "reviewed" the PR and the feature is a little bit far from what you are expecting comparing with slack. This quarter we are a little bit busy fixing and improving features we already have. I'm afraid we already defined which new "features" we gonna be releasing until the end of the year.

  • Rich messages
  • new Admin (rewrite using react)
  • Invite links

But I swear to you, Direct Messages is your feature priority number one for the next quarter, probably until the end of January. Really sorry about the delay...

@ChrissW-R1
Copy link
Contributor

Guys you set the release version to 2.0.0. Now 2.4.1 is released, but we're still waiting for it!
Sure there are other tasks to do, but this one is so much more important for the most users. More than any admin feature or other content types.

This is a primary feature, which could be used in any other team collaboration tool. So, in my opinion it would be the best to set all focus on this and only fix security issues before. In any other case this good software will lose more customers!

@Skygge666
Copy link

Skygge666 commented Jan 17, 2020

Guys you set the release version to 2.0.0. Now 2.4.1 is released, but we're still waiting for it!
Sure there are other tasks to do, but this one is so much more important for the most users. More than any admin feature or other content types.

This is a primary feature, which could be used in any other team collaboration tool. So, in my opinion it would be the best to set all focus on this and only fix security issues before. In any other case this good software will lose more customers!

We lost our patience after waiting over 2 years for this fundamental function, we stay on Slack.
To be honest, and sorry for that, I consider that Rocket Chat is an abandoned project with no future.
Development is focused on irrelevant bullshit instead most basic, most required, fundamental features.

Our tests 2 years ago was something like below:

  • Install Rocket Chat server
  • Basic configuration - add LDAP user database, check if users can log in.
  • Start direct message between 2 users.
  • OK, let's invite someone else. We can't? What? How is this possible? WTF?
  • Tests failed after 15 minutes.
    But OK, we can wait a little for this essential functionality, there is a ticket opened for it.

After 2 years... nothing changed. Rocket Chat gained some bells and whistles instead.
For me this is ridiculous and sad at the same time, this direction is almost like a sabotage.

@danel1
Copy link

danel1 commented Jan 20, 2020

@ggazzo @engelgabriel This should really be taken care off.... :-/

@systembell
Copy link

@engelgabriel what is the hold up on merging this? seriously guys, this is not a great look.

@tobiasreinhard
Copy link

This is really ridiculous. Not putting in such a basic feature. When can we expect the merge?

@rodrigok
Copy link
Member

This PR is planned for this quarter, it will take some time since it will require many changes. It's not only about merge it, we need to take care of the performance, security and usability of this feature to deliver something good.

@ChrissW-R1
Copy link
Contributor

Yay! A new major version, finally we could use ... wait what? This essential feature is still not in Rocket.Chat?
You told us, there is a heavy workload to implement it, because it affects basic structures in the code. Ok, as a software developer I could understand it. But a major version was the perfect opportunity to integrate this feature.

What is the timetable of this? You said "this quarter". The quarter will end at the 31.03.2020, ok let's say we include the whole week, so it is the 05.04.2020. With a little bit goodwill, there are 7 weeks from now. When you will start with the implementation? When you want to finish the work? When the release will come out to use it? What if you do need another major release (SemVer), should be wait for another 5-6 month?

@ggazzo
Copy link
Member

ggazzo commented Feb 17, 2020

@ChrissW-R1 as I told before, we had a feature list to delivery:

  • Rich messages (we released as UIKit)
  • new Admin
  • Invite links

ok, maybe took more time than we expected to finish some of them, but all the features we promised are here, and you can always check the releases notes if you have some doubt about what we have done... thanks for your concerns about our internal "deadline" and how much effort we gonna spend developing this feature... but until now we are still following the plan.

@engelgabriel engelgabriel modified the milestones: 2.3.0, 3.1.0 Feb 20, 2020
@sampaiodiego
Copy link
Member

sampaiodiego commented Mar 26, 2020

closed (and implemented) by #16761 ... thank you for all the effort you put on this.

@GoetheG
Copy link

GoetheG commented Apr 6, 2020

Hey everybody. I want to thank all contributors for their work! This is a great feature. Please be aware of the fact that there are people really appreciating your contribution for Rocket.Chat!

@Sing-Li
Copy link
Member

Sing-Li commented Apr 6, 2020

Thanks @GoetheG Comments like yours (actually on both sides) are greatly appreciated by the team and community.

@ggazzo
Copy link
Member

ggazzo commented Apr 14, 2020

I hope you enjoy the feature, we made a few decisions based on how your DMs works, but we are opened to suggestions :)

@zdumitru
Copy link
Contributor

I hope you enjoy the feature, we made a few decisions based on how your DMs works, but we are opened to suggestions :)

@ggazzo Here is a suggestion - RocketChat/feature-requests#323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
0.63.0
  
Desireable
Development

Successfully merging this pull request may close these issues.

Direct Messages Between Multiple Users