[FIX] Livechat is not working when running in a sub path #9599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (/\/$/.test(baseUrl) === false) { | ||
| baseUrl += '/'; | ||
| } | ||
|
|
There was a problem hiding this comment.
@rodrigok, a variable (baseUrl) was created to deal with __meteor_runtime_config __. ROOT_URL_PATH_PREFIX, would not it be nice to use this same variable below, where __meteor_runtime_config __. ROOT_URL_PATH_PREFIX is mentioned again?
rodrigok
force-pushed
the
hotfix/livechat-subpath
branch
from
536a171
to
e019a99
Compare
renatobecker-zz
approved these changes
Feb 6, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.