Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add ability to disable email notifications globally #9667

Merged
merged 14 commits into from
Sep 20, 2019
Merged

[NEW] Add ability to disable email notifications globally #9667

merged 14 commits into from
Sep 20, 2019

Conversation

ferdifly
Copy link
Contributor

@ferdifly ferdifly commented Feb 9, 2018

@RocketChat/core

Closes #3211

I might add the option to hide message content later on but I think this will do as a first PR.

Please let me know how I can improve this PR (by adding some tests maybe?).

Screenshots:
admin
user

@geekgonecrazy geekgonecrazy changed the title Add ability to disable email globally [NEW] Add ability to disable email globally Feb 16, 2018
@geekgonecrazy
Copy link
Contributor

Thanks for the contribution! Left a comment in line :)

@howq
Copy link

howq commented Apr 30, 2018

@ferdifly hi,when I find the issue of disabling email notification globally.I'm so glad.But I can't find in the 0.64.0 tag.Why this useful rp was not accepted.

@ferdifly
Copy link
Contributor Author

@howq Apparently my commit keeps all e-mails from being sent (see #3211 (comment)). Thanks for reminding me of this, I somehow lost track of this commit due to other stuff going on. I'll try to take a look at it later this week.

@Irker
Copy link

Irker commented Aug 1, 2018

up?

@javiergoni
Copy link

Any update of this?

@ferdifly
Copy link
Contributor Author

Since interest still seems high on this feature I took a look at my branch again.

According to my understanding of the code and terminal output, password recovery mails are still being sent when email notifications are disabled #3211 (comment).

Maybe someone from @RocketChat/core could consider this PR again and let me know what there is left to do. Did my commit 23e0195 address @geekgonecrazy change request correctly?

@RocketChat RocketChat deleted a comment Oct 3, 2018
@ferdifly
Copy link
Contributor Author

@geekgonecrazy I've addressed your change request and merged the latest develop branch. However ci/circleci: build-and-test/hold is stuck pending and I'm unsure whats causing it.

@geekgonecrazy
Copy link
Contributor

That's fine and normal.

@rocketchat/core this seems like a great change to add. I know I personally have needed something like this a few times for disabling email sending.

@sampaiodiego sampaiodiego added this to the 1.5.0 milestone Jul 18, 2019
@sampaiodiego sampaiodiego merged commit 0be1a0b into RocketChat:develop Sep 20, 2019
@sampaiodiego sampaiodiego changed the title [NEW] Add ability to disable email globally [NEW] Add ability to disable email notifications globally Sep 20, 2019
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
@ferdifly ferdifly deleted the add-ability-to-disable-email-globally branch December 1, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to disable email globally
7 participants