Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scrollbars for overflowing popovers #9855

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM rocketchat/base:8

ENV RC_VERSION 0.61.0-develop
ENV RC_VERSION 0.61.1

MAINTAINER buildmaster@rocket.chat

Expand Down
2 changes: 1 addition & 1 deletion .sandstorm/sandstorm-pkgdef.capnp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const pkgdef :Spk.PackageDefinition = (

appVersion = 62, # Increment this for every release.

appMarketingVersion = (defaultText = "0.61.0-develop"),
appMarketingVersion = (defaultText = "0.61.1"),
# Human-readable representation of appVersion. Should match the way you
# identify versions of your app in documentation and marketing.

Expand Down
2 changes: 1 addition & 1 deletion .travis/snap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ elif [[ $TRAVIS_TAG ]]; then
RC_VERSION=$TRAVIS_TAG
else
CHANNEL=edge
RC_VERSION=0.61.0-develop
RC_VERSION=0.61.1
fi

echo "Preparing to trigger a snap release for $CHANNEL channel"
Expand Down
310 changes: 308 additions & 2 deletions HISTORY.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Rocket.Chat",
"description": "The Ultimate Open Source WebChat Platform",
"version": "0.61.0-develop",
"version": "0.61.1",
"author": {
"name": "Rocket.Chat",
"url": "https://rocket.chat/"
Expand Down
5 changes: 5 additions & 0 deletions packages/rocketchat-cors/cors.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ import _ from 'underscore';

import url from 'url';

import tls from 'tls';
// FIX For TLS error see more here https://github.com/RocketChat/Rocket.Chat/issues/9316
// TODO: Remove after NodeJS fix it, more information https://github.com/nodejs/node/issues/16196 https://github.com/nodejs/node/pull/16853
tls.DEFAULT_ECDH_CURVE = 'auto';

WebApp.rawConnectHandlers.use(Meteor.bindEnvironment(function(req, res, next) {
if (req._body) {
return next();
Expand Down
2 changes: 2 additions & 0 deletions packages/rocketchat-emoji-emojione/client/sprites.css
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
}

.emojione.big {
display: inline-block !important;

width: 44px;
height: 44px;
}
Expand Down
3 changes: 2 additions & 1 deletion packages/rocketchat-i18n/i18n/de.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -1796,6 +1796,7 @@
"theme-custom-css": "Benutzerdefiniertes CSS",
"theme-font-body-font-family": "Schrift-Familie für den Textkörper",
"There_are_no_agents_added_to_this_department_yet": "Es wurden bisher keine Agenten zu dieser Abteilung hinzugefügt",
"There_are_no_applications": "Bisher wurden keine oAuth Anwendungen hinzugefügt.",
"There_are_no_integrations": "Es sind keine Integrationen vorhanden",
"There_are_no_users_in_this_role": "Es sind dieser Rolle keine Benutzer zugeordnet",
"This_conversation_is_already_closed": "Die Unterhaltung wurde bereits beendet",
Expand Down Expand Up @@ -2065,4 +2066,4 @@
"your_message_optional": "Ihre optionale Nachricht",
"Your_password_is_wrong": "Falsches Passwort",
"Your_push_was_sent_to_s_devices": "Eine Push-Nachricht wurde an %s Geräte gesendet."
}
}
9 changes: 5 additions & 4 deletions packages/rocketchat-i18n/i18n/en.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -1369,8 +1369,8 @@
"Notification_Duration": "Notification Duration",
"Notification_Mobile_Default_For": "Push Mobile Notifications For",
"Notifications": "Notifications",
"Notifications_Always_Notify_Mobile" : "Always notify mobile",
"Notifications_Always_Notify_Mobile_Description" : "Choose to always notify mobile device regardless of presence status.",
"Notifications_Always_Notify_Mobile": "Always notify mobile",
"Notifications_Always_Notify_Mobile_Description": "Choose to always notify mobile device regardless of presence status.",
"Notifications_Duration": "Notifications_Duration",
"Notifications_Max_Room_Members": "Max Room Members Before Disabling All Message Notifications",
"Notifications_Max_Room_Members_Description": "Max number of members in room when notifications for all messages gets disabled. Users can still change per room setting to receive all notifications on an individual basis. (0 to disable)",
Expand Down Expand Up @@ -1624,7 +1624,7 @@
"run-migration_description": "Permission to run the migrations",
"Running_Instances": "Running Instances",
"S_new_messages_since_s": "%s new messages since %s",
"Same_As_Token_Sent_Via" : "Same as \"Token Sent Via\"",
"Same_As_Token_Sent_Via": "Same as \"Token Sent Via\"",
"Same_Style_For_Mentions": "Same style for mentions",
"SAML": "SAML",
"SAML_Custom_Cert": "Custom Certificate",
Expand Down Expand Up @@ -1895,6 +1895,7 @@
"theme-custom-css": "Custom CSS",
"theme-font-body-font-family": "Body Font Family",
"There_are_no_agents_added_to_this_department_yet": "There are no agents added to this department yet.",
"There_are_no_applications": "No oAuth Applications have been added yet.",
"There_are_no_integrations": "There are no integrations",
"There_are_no_users_in_this_role": "There are no users in this role.",
"This_conversation_is_already_closed": "This conversation is already closed.",
Expand Down Expand Up @@ -2190,4 +2191,4 @@
"your_message_optional": "your message (optional)",
"Your_password_is_wrong": "Your password is wrong!",
"Your_push_was_sent_to_s_devices": "Your push was sent to %s devices"
}
}
2 changes: 1 addition & 1 deletion packages/rocketchat-i18n/i18n/pt-BR.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -1323,4 +1323,4 @@
"your_message_optional": "sua mensagem (opcional)",
"Your_password_is_wrong": "Sua senha está errada!",
"Your_push_was_sent_to_s_devices": "Sua natificação foi enviada para %s dispositivos"
}
}
2 changes: 1 addition & 1 deletion packages/rocketchat-i18n/i18n/pt.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -1348,4 +1348,4 @@
"your_message_optional": "sua mensagem (opcional)",
"Your_password_is_wrong": "Sua senha está errada!",
"Your_push_was_sent_to_s_devices": "Sua natificação foi enviada para %s dispositivos"
}
}
2 changes: 1 addition & 1 deletion packages/rocketchat-lib/rocketchat.info
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "0.61.0-develop"
"version": "0.61.1"
}
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@
}

.emoji.big {
display: inline-block !important;

width: 44px;
height: 44px;
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@
box-shadow: 0 0 2px 0 rgba(47, 52, 61, 0.08), 0 0 12px 0 rgba(47, 52, 61, 0.12);
}

&__content-scroll {

.rc-popover__item {
display:block;
}
}

&__column {
display: flex;
flex-direction: column;
Expand Down
7 changes: 7 additions & 0 deletions packages/rocketchat-ui/client/views/app/popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ Template.popover.onRendered(function() {
});
}

const realTop = Number(popoverContent.style.top.replace('px', ''));
if (realTop + popoverContent.offsetHeight > window.innerHeight) {
popoverContent.style.overflow = 'scroll';
popoverContent.style.bottom = 0;
popoverContent.className = 'rc-popover__content rc-popover__content-scroll';
}

if (activeElement) {
$(activeElement).addClass('active');
}
Expand Down