[FIX] Delete user without username was removing direct rooms of all users #9986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
reviewed
Mar 2, 2018
packages/rocketchat-cors/cors.js
Outdated
| import tls from 'tls'; | ||
| // FIX For TLS error see more here https://github.com/RocketChat/Rocket.Chat/issues/9316 | ||
| // TODO: Remove after NodeJS fix it, more information https://github.com/nodejs/node/issues/16196 https://github.com/nodejs/node/pull/16853 | ||
| tls.DEFAULT_ECDH_CURVE = 'auto'; | ||
|
|
||
| // Revert change from Meteor 1.6.1 who set ignoreUndefined: true | ||
| // more informatin https://github.com/meteor/meteor/pull/9444 | ||
| Mongo.setConnectionOptions({ |
There was a problem hiding this comment.
May I ask why this is being done in the CORS package? That's my only conundrum with this..
There was a problem hiding this comment.
My only guess is because it is the first one to be loaded
graywolf336
reviewed
Mar 2, 2018
| if (room) { | ||
| if (room.t !== 'c' && room.usernames.length === 1) { | ||
| RocketChat.models.Rooms.removeById(subscription.rid); // Remove non-channel rooms with only 1 user (the one being deleted) | ||
| // Users without username can't do anything, so there are nothing to remove |
There was a problem hiding this comment.
Grammar correction. "..so there is nothing to remove" 😉
sampaiodiego
force-pushed
the
hotfix/user-delete-without-username
branch
from
a560e31
to
1ac5052
Compare
sampaiodiego
force-pushed
the
hotfix/user-delete-without-username
branch
from
1ac5052
to
ca487a4
Compare
sampaiodiego
approved these changes
Mar 3, 2018
|
based on @graywolf336 's comment my suggestion is renaming the CORS package to something like |
sampaiodiego
added a commit
that referenced
this pull request
Mar 3, 2018
…sername [FIX] Delete user without username was removing direct rooms of all users
Merged
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 9, 2018
* master: Revise test job, fix cache path, fix artifact path, update README Trying to fix memory issue during meteor build Add S3 upload script Remove root-priviledged command switch gitlab ci config to use shell executor Try another build Fix another stupid docker image reference try to fix a build error with katex Fix root permission for meteor command everywhere Try to fix build with gitlab-ci Add --allow-superuser to fix meteor build error on root permission First try with a gitlab-ci build Bump version to 0.62.1 Merge pull request RocketChat#9986 from RocketChat/hotfix/user-delete-without-username Merge pull request RocketChat#9988 from RocketChat/fix-new-channel Merge pull request RocketChat#9960 from RocketChat/hotfix-subscription-without-room-ui Merge pull request RocketChat#9982 from RocketChat/fix-two-factor-login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meteor 1.6.1 introduced a new default setting to MongoDB driver
ignoreUndefined: truewhich can remove fields withundefinedvalues from the query, that execute a different behavior than expected when deleting users without usernames executing the deletion agains all direct rooms with the query:rather than
This PR rollback that MongoDB option and does not tries to remove data for users without username cuz they can't have message, subscriptions, rooms, etc before set their username.