Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectFiltered: Wrong keyboard navigation #162

Closed
gabriellsh opened this issue Mar 6, 2020 · 2 comments · Fixed by #169
Closed

SelectFiltered: Wrong keyboard navigation #162

gabriellsh opened this issue Mar 6, 2020 · 2 comments · Fixed by #169
Assignees
@ggazzo
Labels
🐛 Bug Something isn't working

Comments

@gabriellsh
Copy link
Member

Description
Choosing an option with the arrow keys selects the wrong one when filter is applied.

Steps to reproduce
Open select, filter results, select option with keyboard and press enter.

Insert an image/gif

Select keyboard filter bug
@gabriellsh gabriellsh added the 🐛 Bug Something isn't working label Mar 6, 2020
@TaimurAzhar
Copy link
Contributor

Hello, I think I have solved this issue. Creating the PR currently. It took me a while.

TaimurAzhar added a commit to TaimurAzhar/Rocket.Chat.Fuselage that referenced this issue Mar 15, 2020
@TaimurAzhar
fixed issue RocketChat#162
1c43acc
@TaimurAzhar TaimurAzhar mentioned this issue Mar 15, 2020
Merged
@dougfabris
Copy link
Member

Fixed here: #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggazzo ggazzo

Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: SelectFiltered: Wrong keyboard navigation TaimurAzhar/Rocket.Chat.Fuselage
4 participants
@ggazzo @dougfabris @TaimurAzhar @gabriellsh