Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Pod Annotations to All Pods #150

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Map Pod Annotations to All Pods #150

merged 5 commits into from
Jun 14, 2024

Conversation

javieragomezo
Copy link
Collaborator

@javieragomezo javieragomezo commented Jun 6, 2024 •
edited
Loading

Annotations can be added globally or separately through the rocketchat.annotations template.

  • Global annotations: the annotations will be mapped to the following pods: account, authorization, presence,ddp-streamer, stream-hub, rocketchat(meteor)
  • Separate annotations: each microservice can have its own set of annotations (it overrides the global annotations)

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javieragomezo javieragomezo marked this pull request as draft June 12, 2024 16:35
javieragomezo and others added 3 commits June 12, 2024 12:13
@javieragomezo
Annotations can be added globally or separately through the rocketcha…
983996b 
…t.annotations template
@javieragomezo
Update README.md
f8c0f3d 
Additional description for the annotations (global and per microservice)
@javieragomezo
Update README.md
058dbba 
Corrected typo in the podAnnotations key
@debdutdeb debdutdeb marked this pull request as ready for review June 14, 2024 02:08
@debdutdeb debdutdeb merged commit 4a6bc8c into RocketChat:master Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debdutdeb debdutdeb debdutdeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javieragomezo @CLAassistant @debdutdeb