Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor asynchronous calls in the code to use async/await #50

Open
wants to merge 3 commits into
base: javascript
Choose a base branch
from

Conversation

arthurTemporim
Copy link
Collaborator

[WIP]

This PR is about issue #47 .

  • refactor security.js
  • refacotr respond.js

To run hubot in docker I needed to uncomment mongo-init-replica in docker-compose.yml, tell me if it's wrong to do it.

In security.js the solution was simple, but in respond.js I need to create a new method, that I called getResult() to simplify the code.

I just ran manual tests.

Signed-off-by: ArthurTemporim <arthurrtl@gmail.com>
Signed-off-by: ArthurTemporim <arthurrtl@gmail.com>
Signed-off-by: ArthurTemporim <arthurrtl@gmail.com>
Signed-off-by: Matheus Bernardo <matheussbernardo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant