Don't use toastr when notifications are blocked. #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastienvercammen this was discussed in the original PR: |
|
@pogo-excalibur Yes, it definitely was, but we've gotten reports about changing the behavior because it's more intuitive. |
|
@sebastienvercammen fair enough 🤷 |
|
@pogo-excalibur Clarification on the decision to change the behavior. |
BrownSlaughter
approved these changes
Sep 27, 2017
pogo-excalibur
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a client denies Notifications permission, we shouldn't show any notifications at all. We should assume the user intentionally blocked them so they wouldn't see any notifications at all.
toastr fallback is still enabled for browsers that don't support the Notifications API.
Motivation and Context
By popular demand.
Types of changes
Checklist: