Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use toastr when notifications are blocked. #2317

Merged
merged 1 commit into from Sep 27, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions static/js/map.js
Expand Up @@ -1909,9 +1909,9 @@ function sendNotification(title, text, icon, lat, lon) {
/* Push.js requests the Notification permission automatically if
* necessary. */
Push.create(title, notificationDetails).catch(function () {
/* Push.js doesn't fall back automatically if the user denies the
* Notifications permission. */
sendToastrPokemonNotification(title, text, icon, lat, lon)
/* Don't do anything if the user denies the Notifications
* permission, it means they don't want notifications. Push.js
* will fall back to toastr if Notifications are not supported. */
})
}

Expand Down