JSON Support for plugins #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed JSONSerializer
|
Hi! The idea is very good and was considered by me the other day. First of all, you should open an Issue with this topic and find out the opinion of others. Then publish a Pull Request. So another erroneous point, do not close your pull requests as well as issues. Sunnamed434 closes the pull request itself, doing so by publishing. |
|
Purpose of this is to discuss It here, no matter if its an issue or not. I closed the pr because I forgot to removed unused Code. |
|
Please make another PR or bump the latest updates from the master branch of this repo, because this one has conflicts due to an outdated branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseJsonForPlugins bool at Rocket.Config.xml
Now you can add comments to the JSON config file
Code:
[JsonConverter(typeof(JsonExtension), "Name")] public string Name = "test";Result:
{ "Name": "test"/*Name*/, }