New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anyone else having issue with LinkedIn provider ? #87
Comments
I am guessing this is the error: https://github.com/RockstarLabs/OwinOAuthProviders/blob/master/Owin.Security.Providers/LinkedIn/LinkedInAuthenticationHandler.cs#L238 Now, 405 could be from linked in, but i do not know at this point |
I'm getting the same issue, only started today and I'm also getting the 405 (Method Not Allowed). Still haven't figured out if it's LinkedIn or something to do with the code. I'm looking at the requests in Fiddler now and It seems fine so far. |
ye. Was just discussing this with identity server guys. Suggestion was to debug it by hand doign the http calls to see where it goes wrong. Must be in the code 2 token exchange. My guess is that linkedin changed something since our codebase has not changed since last week and the issue started this morning |
reproduced it now: heres the response of the token. |
the request headers are also there in a comment now. |
Many thanks for bringing this to our attention, @s093294. I will look into this now. Do bare in mind that it was @jerriep who implemented this provider and not me - I have not touched this provider before. If you find a solution before me, please create a pull request. Cheers. |
I dont think the provider is bad. I think its on linkedin https://www.linkedin.com/uas/oauth2/accessToken endpoint that is broken. |
POST https://www.linkedin.com/uas/oauth2/accessToken HTTP/1.1 grant_type=authorization_code&code=AQTNeGrEj1QeV2MOudoi8T1fx1fov-05oSp5dg-HidNxpHtKJ_CkbfcsNyKvuY3eIztVtHQJb883P8QzB5vVvdjYYpR0T9eAjComHVc55quXCs6_RR8&redirect_uri=http%3A%2F%2Flocalhost%3A1729%2Fsignin-linkedin&client_id=&client_secret= Just removed the secret/clientid, but above results in method not found. |
When did you first notice the problem? I wonder if LinkedIn have made a statement yet. |
started this morning. noticed the error first time 5 hours ago. Everything looks correct according to docs: https://developer.linkedin.com/docs/oauth2 I have seen nothing from linkedin |
+1 confirm that the provider isn't the problem. So either a problem on LinkedIn's end or they changed something and decided not to tell developers again... |
Thanks for the investigation guys. Given it seems to be on the LinkedIn side I would suggest giving it a few hours and see whether it works itself out. |
I want to test this out but I cannot cannot so much as register an account with LinkedIn at the moment. It always tells me the verification failed. I had a friend test this in America and it happens for him too. This could be related to our problem here. It looks like their authentication server is being erratic. |
there was an update in an answer that might help. When confirmed (if this is the case) How fast can we fix this and get new nugets out? (Asking to find out if i should start making a local copy of the provider to hot fix it local (when solution exists)) or just wait for new nugets. |
I am not sure. What do you think, @jerriep? I am inclined to push an updated package as soon as we have a confirmed fix. |
Sorry guys, it is getting late evening already here by me, but if you get a fix for that by all means please update package and push :) |
Cool. I am still unable to create a LinkedIn account 😠. @s093294, if you submit a pull request, I will be very grateful. I promise I will tend to it promptly. |
Sure. Right now I dont think the fix is in the provider. According to the SO answer, if the header is the issue, it is not set by this library sadly :( so not something that can be fixed easily. |
In .NET, we were able to work around this by explicitly disabling the Expect: 100-Continue for the LinkedIn API URI. Something like this: protected void Application_Start()
{
var servicePoint = System.Net.ServicePointManager.FindServicePoint(new Uri("https://www.linkedin.com/uas/oauth2/accessToken";));
servicePoint.Expect100Continue = false;
} I'm not proud of this but it's working locally. OK, we're getting intermittent issues with this solution, as well. Stay tuned. |
Just tested it also and noticed that it actually worked once and then after deploying it didnt work after all. Might be missing something. |
Looks to be working here also. Should we push out some new nugets based on this to help people using the provider? Would be nice |
Awesome 😄. Can you confirm that it works after deploying too? |
Either i need to distribute local dlls to do so or wait for updates nugets. Can we generate prerelease packages? But I dont see any reason why it would not work in production also with the change made. |
I am being mindful of this comment:
I interpreted that as "the solution works locally but not remotely." I will create a prerelease package now. |
I can understand that. I might just have been a little to fast in deploying and could have found out locally that it didnt work as expected. I still think its a good idea to add this as a prerelease until linkedin comes with a statement. This allows us to update and get a fix that work until we know if linkedin reverts anything or do further changes to the endpoint. |
I agree. Working on it now. |
I just published a pre-release with the proposed fix. You can find it here. Please report back. |
Deployed to our staging deployment and sofar no issues. Deploying to production now also |
I posted the prerelease as a answer also to my SO question: http://stackoverflow.com/questions/29492598/post-https-www-linkedin-com-uas-oauth2-accesstoken-http-1-1-results-in-method/29499394#29499394 |
Nice one. I hope @linkedin acknowledge this apparent breaking change soon. |
Has anyone heard anything from @linkedin? (@s093294 @noeloc @jerriep @jlcj1974) I am wondering whether I should keep the |
Havent heard anything yet. I would consider the fix stable. But there is always the chance that linkedin changes something again and that could be considered a new fix. I would keep it as a prerelease for a few days or until @linkedin gives a statement, since this will alert users of the lib to pay attention. If you release 1.17 and linkedin fixes/change something that yet again require a new update of the nugets, this change will reflect badly on the lib instead of on linkedin. Just my 2cent. |
I totally agree. 🐻 |
Hey guys, thanks for all these fixes. From past experience, I think waiting for any official response from LinkedIn is futile, as communicating with developers is not their strong point ;) That being said, I am totally cool with keeping it in pre-release mode for now. I am busy working my way through some pull requests, so hanging on before releasing it gives me more time to do that. |
Hiya everybody, I have the same issue with LinkedIn, but unfortunately Expect100Continue fix doesn't work for me (at least now). So for now I'm Authorization parameters (like grant_type, code, client_secret etc.) in query part of URI (instead of body of POST request to https://www.linkedin.com/uas/oauth2/accessToken endpoint). Sad, but it works. Please checkout mine commit if you have same problems as me CrazyMORF@70d0f22 |
The prerelease package we created do still work here. (Just tested it). |
Hi All, I am also continuing to get the same error even after upgrading to pre release package. i.e access_denied. What should I check for? |
@nikesh-thinkbridge Have you followed this guide exactly?http://www.oauthforaspnet.com/providers/linkedin/guides/aspnet-mvc5/ |
Another tip I can propose is to look at the network traffic in Chrome Developer tools. Make sure though that you have "Preserve Log" enabled so the requests does not clear everytime there is a redirect. A lot of time the clue is hidden somewhere inside the network traffic - you just need to go hunting... |
yes it was all working till yesterday morning, suddenly stopped working last evening. Then I installed the pre release version as suggested, but I am still getting the same error. |
Sure...but the token call would be made by the middleware and not visible in the log right? |
It depends on what is wrong and when the error happens. When LinkedIn redirects back to your redirect URL it will happen in the browser, and it can happen that it includes more info inside that redirect response. Typically if redirect URLs does not match, scopes are incorrect, or other cases you will be able to see more details. So don't just dismiss it out of hand. It is just one way to try and track down the problem. If you do not see anything in the network traffic then we can eliminate that and move on to try something else. |
Of course if it does happen on the middleware level then you can always try and use Fiddler to monitor network traffic as well. Seeing as it does work for some people we need to track this down on your end. I will try it quickly on my side and see whether I get the same issue. |
Yeah guys, it works 100% on my side as well. You will need to monitor the network traffic on your side with something like Fiddler to see whether you can get a clue about what may be wrong. Is there anything "strange" about your configurations? Maybe a non-standard callback URL, or non standard scope or anything like that? |
Thanks jerrie...My bad....Had changed the url for testing it on local which is on a different key than the production one. Changed it and all works like charm!!! |
No problem :) Glad you're sorted |
Thanks to you! But what can we expect from our friends at Linked in......more surprises???!! |
Most probably ;) These companies aren't always very good with communicating changes to developers... :( |
Hey everyone. I release 1.17 by mistake without LinkedIn fix, but realised my mistake and released 1.17.1 with LI fix included. I tested and all works fine. I will close this issue. If anything else comes up feel free to reopen or create a new issue |
Hi everyone, We applied the patch yesterday and it worked fine. Is there anyone with same problem ? |
I cannot confirm the problem. Our linkedin sign on has worked since the updated package was added. |
We deployed yesterday and the patch is still working for us. On Apr 9, 2015, at 11:36 AM, trotin <notifications@github.commailto:notifications@github.com> wrote: Hi everyone, We applied the patch yesterday and it worked fine. Is there anyone with same problem ? — |
Hi @trotin, Many thanks for bringing another potential issue to our attention. Once I saw your comment I tested the patched LinkedIn provider on I will leave this issue closed for now, as it seems to be working for everyone else. |
Today our users stopped being able to login with linked in.
Onlything I have right now from our traces at this point.
I inspect the webredirects and things seem to look fine and I suspect that its in the code to token exchange.
The text was updated successfully, but these errors were encountered: