Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to binding.gyp and example.js were necessary so that zorba-node worked on Ubuntu with a 'standard' Zorba installation (from the Juan repos).
On Redhat, I had to make custom changes to binding.gyp that are not portable, but the change to example.js was still required to get zorba-node to work on RedHat. Basically the string in this line
Needed to be quoted, like this:
I guess it must have worked on a Mac and Windows, but the test resulted in "error" on linux. Replaced it with Zorba's own "test" as seen here http://www.zorba.io/documentation/latest/zorba/build/build_and_install#testing_install