Improve disabling of autocomplete and autofill #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves our automatic ability to disable autocomplete/autofill.
There seem to be two systems which can display dropdowns on top of our dropdown:
autocomplete="off"
will disable autocomplete, but not autofill. Any unrecognized value (e.g.autocomplete="chrome-off"
) will disable autofill, but not autocomplete.There is a Stack Overflow answer which explains it a bit more in detail.
With this pull request we add some of Chrome' autofill heuristics and disable the autofill in these cases. With this patch I have not got a single suggestion dropdown menu from Chrome for the last three months.