Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve disabling of autocomplete and autofill #55

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

Abestanis
Copy link
Contributor

Improves our automatic ability to disable autocomplete/autofill.

There seem to be two systems which can display dropdowns on top of our dropdown:

  • Autocomplete, which suggests words that were previously typed into a field.
  • Autofill, which will suggest stored information (e.g. name, address, email...) for fields where it thinks it is appropriate.

autocomplete="off" will disable autocomplete, but not autofill. Any unrecognized value (e.g. autocomplete="chrome-off") will disable autofill, but not autocomplete.
There is a Stack Overflow answer which explains it a bit more in detail.

With this pull request we add some of Chrome' autofill heuristics and disable the autofill in these cases. With this patch I have not got a single suggestion dropdown menu from Chrome for the last three months.

@RoelVB
Copy link
Owner

RoelVB commented Sep 13, 2021

Looks good. Thanks

@RoelVB RoelVB merged commit 3f21e0f into RoelVB:dev Sep 13, 2021
@Abestanis Abestanis deleted the feature/autocomplete branch September 13, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants