Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove window_size arg from Conformer call #103

Merged

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Jan 25, 2024

Description

Remove window_size arg from conformerPeakPicking call in extracted ion chromatogram server workflow.

Fixes #102

Type of change

Please delete options that are not relevant.

  • [ x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested using the GUI with the example test data

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my code
  • [ x ] My changes generate no new warnings
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] Any dependent changes have been merged and published in downstream modules

Contents (#103)

Other

  • remove window_size arg from Conformer call

@singjc singjc linked an issue Jan 25, 2024 that may be closed by this pull request
@singjc singjc added the bug Something isn't working label Jan 25, 2024
@singjc singjc linked an issue Jan 25, 2024 that may be closed by this pull request
@singjc singjc merged commit 5808e3e into dev Jan 25, 2024
10 checks passed
@singjc singjc deleted the 102-bug-unexpected-keyword-argument-for-conformer-peak-picking branch January 31, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unexpected keyword argument for conformer peak picking
1 participant