Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Transition list loaders #23

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Nov 4, 2023

Added loaders for a spectral library, either loads a generic transition TSV or loads a PQP. The main TransitionList class has a bunch of getter methods for populating UI selection widgets or for getting specific information for protein/peptide/precursor/product level.

@singjc singjc self-assigned this Nov 4, 2023
@singjc singjc requested a review from jcharkow November 4, 2023 05:55
@singjc singjc added enhancement New feature or request refactor Refactoring code labels Nov 4, 2023
Copy link
Collaborator

@jcharkow jcharkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. One idea is to generalize the transitionTSV loader more to accept those with multiple different column names so not only supporting OSW workflow

massseer/loaders/SpectralLibraryLoader.py Outdated Show resolved Hide resolved
massseer/loaders/TransitionTSVLoader.py Show resolved Hide resolved
massseer/loaders/TransitionTSVLoader.py Show resolved Hide resolved
@singjc singjc requested a review from jcharkow November 6, 2023 05:51
Copy link
Collaborator

@jcharkow jcharkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just general python question but I believe it is not an issue

massseer/loaders/TransitionTSVLoader.py Show resolved Hide resolved
@singjc
Copy link
Collaborator Author

singjc commented Nov 7, 2023

Looks good! just general python question but I believe it is not an issue

Great, can you do the merge if all looks good.

@jcharkow jcharkow merged commit 13fb9a7 into patch/masterRefactor Nov 7, 2023
@singjc singjc deleted the patch/transition_loaders branch November 7, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants