Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureMap - TransitionGroup Linking #24

Merged

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Nov 4, 2023

I added Mobilogram and Spectrum classes, similar to the Chromatogram class.

I also added a FeatureMap class that is used to store the a feature dataframe (mz, rt, im, intensity, mslevel etc) that is obtained from a targeted extraction experiment. The class has methods to extract chromatograms, mobilgorams, and spectra and stores them in their associated classes.

I modified the TransitionGroup class to load data from a FeatureMap, which then loads the associated precursor and transition chromatograms, mobilograms and spectra into the TransitionGroup. I also added a protein property to attached the Protein class which contains information about the Protein and downstream class levels.

@singjc singjc requested a review from jcharkow November 4, 2023 20:10
@singjc singjc self-assigned this Nov 4, 2023
@singjc singjc added the enhancement New feature or request label Nov 4, 2023
Copy link
Collaborator

@jcharkow jcharkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think it may conflict with other branches slightly but we will get there when we get there

@jcharkow jcharkow merged commit 64a9975 into patch/masterRefactor Nov 9, 2023
@jcharkow jcharkow deleted the patch/featuremap_transition_group_linking branch November 9, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants