[FIX][FEATURE] add zeros to chroms/mobs #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low intensiyt chromatogram/mobilograms can look strange because no "0" is added for if the transition is not present. Change to_chromatogram() and to_mobilogram() conversion functions to add a 0 intensity point so that chromatograms do not look as strange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Low intensity chromatograms look strange because there are a bunch of zero points per transition that are filtered out.
Solution:
Change to_chromatogram and to_mobilogram methods to function across all transitions. Thus if one transition is present and the rest are 0, a 0 point will be added. This leads to plots that make more sense.
Before:
After: