Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/theme logo switch #83

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Patch/theme logo switch #83

merged 3 commits into from
Jan 15, 2024

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Jan 15, 2024

Added theme detection using javascript. This will detect if the theme is dark or light, and use the appropriate logo. This however, will only detect the theme on the initial load of the app or if the app is refreshed, it will not detect a change in theme if it is changed via the settings (unless refreshed).

See:

https://discuss.streamlit.io/t/check-if-the-app-is-in-dark-mode-or-light-mode-at-runtime/20222/8

@singjc singjc self-assigned this Jan 15, 2024
@singjc singjc added enhancement New feature or request GUI GUI related labels Jan 15, 2024
Copy link
Collaborator

@irahorecka irahorecka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this dependency in pyproject.toml? I believe pyproject.toml is what's pushed as a PyPI dependency for pip installs, while setup.cfg is metadata for the PyPI project landing page

@singjc
Copy link
Collaborator Author

singjc commented Jan 15, 2024

Can you add this dependency in pyproject.toml? I believe pyproject.toml is what's pushed as a PyPI dependency for pip installs, while setup.cfg is metadata for the PyPI project landing page

Done 👍

@irahorecka
Copy link
Collaborator

Looks good! I'll go ahead and merge this.

@irahorecka irahorecka closed this Jan 15, 2024
@irahorecka irahorecka reopened this Jan 15, 2024
@irahorecka irahorecka merged commit 8de86e4 into dev Jan 15, 2024
@irahorecka irahorecka deleted the patch/theme_logo_switch branch January 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI GUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants