Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it safe to call Thing.with_role(:admin, user) even if user is not persisted #480

Merged
merged 3 commits into from
May 11, 2018

Conversation

TylerRick
Copy link
Contributor

This will return an empty result now (like it used to) instead of raising an exception.

Fixes #382

…t persisted

This will return an empty result now (like it used to) instead of
raising an exception.

Fixes RolifyCommunity#382
@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Coverage remained the same at 93.089% when pulling 3edafe8 on TylerRick:fix-382 into 99ec022 on RolifyCommunity:master.

Copy link
Member

@EppO EppO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR

@EppO EppO merged commit c05551d into RolifyCommunity:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants