[Das_Schwarze_Auge_4-1] In-Chat Confirmation Rolls #12021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/from Base64 encoded strings
* Add melee roll names to ability call generation
* Reintroduce lowercasing method to work around bad attribute naming (may be tackled in the future)
…epending on "msg"
… utilizing (nested) roll macros for the Ausfall manoeuvre (lunge)
Nested rolls need to be escaped and going beyond three levels of nesting by hand is madness. Also, readjusting the same macro to the current level of nesting poses and extra challenge for misplaced special characters. To minimize time lost finding such bugs, roll macros (for use in roll buttons) can now be generated from two objects: the 'macros' object and the 'reuse' object. The reuse object contains macros (and can contain other macros defined in the same reuse object) to allow easy generation of almost arbitrarily complex nested roll macros. The macros object defines the variables available to the roll and can call reuse macros as well. Combined, both allow to build complex macros in a rather elegant and easy to understand way. The output is the string for use in a roll button. The input sanitation present was written with a user of the roll macro generator in mind, not an intelligent attacker trying to bypass certain checks.
Proof of concept for utilizing the Roll Macro Generator.
This uses <span> within the button description that can be styled later to imitate real roll buttons.
…se appropriate section names for parryweapons and shields
…ValuesAndWeaponNumber() * Create more general calculateTpKKMod() function * Use calculateTpKKMod() in calculateTpKKModFromValuesAndWeaponNumber()
Note: Currently, the advantage 'ambidextrous' and the special skills 'left hand', 'ambidextrous fighting I' and 'ambidextrous fighting II' are not considered when rolling parryweapon attacks.
… the left/wrong hand taking into consideration the advantage ambidextrous and the special skills left hand, ambidextrous fighting 1 and ambidextrous fighting 2 * Add default value for the attribute
This attribute has been replaced for a long time and sees no use in the sheet.
…iv' and 'TP_Bonus_Aktiv' with sheetworker scripts
Hide those that are non-functional for now and the near future/release.
|
Character Sheet Info Roll20 Internal Use only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Required
Changes / Description
New Features
Interface/Style
Fixes
Miscellaneous
Any old used attributes are still usable via an automatically running migration function.