[Das_Schwarze_Auge_4-1] Code Cleanup and Dev Split #12586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This marks the beginning of a separate dev directory with split files. A very simple Makefile is used to build the sheet's HTML and CSS files from the split files. From this commit on, no work should be done in the generated files (sheet's HTML and CSS files).
Former mix of tabs and spaces reduced to tabs only, accompanied by some manual indentation fixes.
|
Character Sheet Info Roll20 Internal Use only. |
|
Hi @kreuvf These changes look great. I suppose one thing I'd ask: could you please write a readme or similar to explain how one should use your makefile? That'll allow anyone who comes after you to be able to help update the project in the future. |
… and without Make
|
Thank you very much for your feedback. Do you think this is enough? |
|
Hey @kreuvf That's spectacular, thanks! Really great work here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Required
Changes / Description
I had been thinking about this for a very long time, but finally I decided to just do it: After having turned off legacy parsing in the previous pull request, it was time to get rid of even more legacy. Both sheet files are now pieced together from several small and handy topic-centred files using a simple Makefile.
The complete diffs look awful, run with
--ignore-all-spaceas I converted all indentation to the same character while fixing borked indentation levels.Having these changes at this point groups it together with the legacy parsing changes which also affected rather large parts of the files leading to ugly diffs when comparing versions before with versions after them. Given the fact that I am probably the sole active contributor to this sheet anyway, this should not impact any other developers.
I have been playtesting this in two sessions with my main group and we did not stumble upon any issues.