Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D&D 3.5] Add new fields "classes" for multiplayer character #9220

Merged
merged 39 commits into from Jul 20, 2021
Merged

[D&D 3.5] Add new fields "classes" for multiplayer character #9220

merged 39 commits into from Jul 20, 2021

Conversation

hoyer555
Copy link
Contributor

Changes / Comments

Add for new fields "classes" in PC and NPC sections, now it's possible to indicate all classes of a character.

Roll20 Requests

Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

  • Does the pull request title have the sheet name(s)? Include each sheet name.
  • Is this a bug fix?
  • Does this add functional enhancements (new features or extending existing features) ?
  • Does this add or change functional aesthetics (such as layout or color scheme) ?
  • If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
  • If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@nmbradley
Copy link
Collaborator

Hi @hoyer555 I notice that this PR has changes to the individual translation json files. We no longer accept PRs that contain changes for these files, even for new translation keys. Would you be able to adjust the PR so you are not attempting changes, please? Until then, I cannot accept these changes.

@hoyer555
Copy link
Contributor Author

Hi, for sure.
If I have understood correctly: I must remove new attributes from all json files inside the folder "translations", I must add all new key only in the "translation.json" file in the main folder, right?

@hoyer555
Copy link
Contributor Author

I have removed all translations.

@nmbradley
Copy link
Collaborator

Thanks!

@nmbradley nmbradley merged commit 944ecb8 into Roll20:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants