Add linter (#10)

.github/workflows/lint.yml

@@ -0,0 +1,12 @@
+name: Lint
+on:
+  push:
+jobs:
+  lint:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3

controllers/routes.go

@@ -54,5 +54,8 @@ func SetupRouter() {
 }
 
 func runServer(router *gin.Engine) {
-	router.Run(":8080")
+	err := router.Run(":8080")
+	if err != nil {
+		panic(err)
+	}
 }

controllers/synchronization.go

@@ -8,7 +8,11 @@ import (
 )
 
 func Sync(c *gin.Context) {
-	roms.SyncRomFiles()
+	err := roms.SyncRomFiles()
+	if err != nil {
+		c.JSON(http.StatusInternalServerError, gin.H{"message": "Error while syncing"})
+		return
+	}
 
 	c.JSON(http.StatusOK, gin.H{"message": "Started syncing..."})
 }

go.mod

@@ -1,6 +1,6 @@
 module github.com/RomManager/server
 
-go 1.19
+go 1.20
 
 require github.com/goccy/go-json v0.10.2 // indirec
 

gridapi/requests.go

@@ -15,7 +15,10 @@ func SearchForGame(gameName string) (GameResponse, error) {
 
 	dataRes := new(ArrayDataResponse)
 
-	UnmarshalData(resp, dataRes)
+	err = UnmarshalData(resp, dataRes)
+	if err != nil {
+		return GameResponse{}, err
+	}
 
 	if len(dataRes.GameArray) == 0 {
 		return GameResponse{}, nil
@@ -34,7 +37,10 @@ func GetGameGrid(gameID int) (GridResponse, error) {
 
 	dataRes := new(ArrayGridResponse)
 
-	UnmarshalData(resp, dataRes)
+	err = UnmarshalData(resp, dataRes)
+	if err != nil {
+		return GridResponse{}, err
+	}
 
 	if len(dataRes.GridArray) == 0 {
 		return GridResponse{}, nil

main.go

@@ -11,10 +11,6 @@ import (
 )
 
 func main() {
-	RunServer()
-}
-
-func RunServer() {
 	fmt.Println("Welcome to the RomManager server")
 	fmt.Printf("Loaded config with SteamGridDBEnabled: %v\n", config.Config().GridAPIEnabled)
 

roms/synchronization.go

@@ -27,8 +27,7 @@ func SetupDirectories() {
 }
 
 // TODO: Write method for check if files are missing
-func SyncRomFiles() {
-
+func SyncRomFiles() error {
 	dataPath := config.Config().DataPath
 
 	if config.Config().DataPath == "data/" {
@@ -40,13 +39,18 @@ func SyncRomFiles() {
 	// Iterate through the each emulator folder
 	for _, emulator := range EmulatorList {
 		emulatorPath := dataPath + emulator.FolderName
-		walkThroughDir(emulatorPath, emulator)
+		err := walkThroughDir(emulatorPath, emulator)
+		if err != nil {
+			fmt.Println(err.Error())
+			return err
+		}
 	}
+	return nil
 }
 
 // TODO: Make log process a bit cleaner
-func walkThroughDir(path string, emulator Emulator) {
-	filepath.Walk(path, func(path string, info os.FileInfo, err error) error {
+func walkThroughDir(path string, emulator Emulator) error {
+	return filepath.Walk(path, func(path string, info os.FileInfo, err error) error {
 		c := color.New(color.FgCyan)
 		if err != nil {
 			fmt.Println(err.Error())
@@ -61,7 +65,11 @@ func walkThroughDir(path string, emulator Emulator) {
 		// Check if a rom with the filepath already exists; if not -> Save to roms db
 		if !models.CheckRomExistsByFilepath(path) {
 			rom := createRom(c, path, info.Name(), emulator.FolderName)
-			rom.SaveRom()
+			_, err := rom.SaveRom()
+			if err != nil {
+				fmt.Println(err.Error())
+				return err
+			}
 			c.Printf("Didn't find in DB --- Created a new entry --- Continuing...\n")
 			return nil
 		}