fix: august event placeholder visible event in upcoming events page #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_MONTHS_WITHOUT_GENERATED_UPCOMING_EVENTS Roma-JS#80
✅ Deploy Preview for romajs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FaberVitale
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an env var,
PUBLIC_MONTHS_WITHOUT_GENERATED_UPCOMING_EVENTS, that allows to not render specific placeholder months.Why?
This logic has been added in order to not render an August placeholder.
Current config
https://github.com/Roma-JS/roma-js-on-astro/pull/81/files#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dR25
How to use PUBLIC_MONTHS_WITHOUT_GENERATED_UPCOMING_EVENTS
Issues
Closes #80