Fix for Group Policy enforced include/exclude lists not being imported corrected #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Get-ExcludedApps where GPO is in use to properly generate the array
Updated Get-IncludedApps to work correctly with GPO source.
add log for excluded / included apps
Romanitho
reviewed
Mar 8, 2024
| $AppIDs = [Microsoft.Win32.Registry]::GetValue($Key, $ValueName, $false) | ||
| [PSCustomObject]@{ | ||
| Value = $ValueName | ||
| Data = $AppIDs.Trim() |
There was a problem hiding this comment.
Shouldn't we keep the Trim control?
| $AppIDs = [Microsoft.Win32.Registry]::GetValue($Key, $ValueName, $false) | ||
| [PSCustomObject]@{ | ||
| Value = $ValueName | ||
| Data = $AppIDs.Trim() |
There was a problem hiding this comment.
Shouldn't we keep the Trim control?
There was a problem hiding this comment.
Add that back in and updated the PR
Romanitho
reviewed
Mar 12, 2024
| @@ -245,7 +245,8 @@ if (Test-Network) { | |||
| New-Item "$WorkingDir\logs\error.txt" -Value "Whitelist doesn't exist in GPO" -Force | |||
| Exit 1 | |||
| } | |||
| $toUpdate = $toUpdate.Data | |||
| $toUpdate = $toUpdate | |||
| @@ -254,7 +255,8 @@ if (Test-Network) { | |||
| New-Item "$WorkingDir\logs\error.txt" -Value "Blacklist doesn't exist in GPO" -Force | |||
| Exit 1 | |||
| } | |||
| $toSkip = $toSkip.Data | |||
| $toSkip = $toSkip | |||
There was a problem hiding this comment.
yep that'd be the same, I've removed that whole line now
|
I went through different path.. |
|
Added the uri fetching. It does seem odd you are creating custom objects (key value pair) then ignoring those in the main code base, question if that is needed or you just need an array of the items, which is what I'm doing. I'm mainly focused on the excluded apps section, as the original code wasn't fully working. New code does seem happy though it can always be slightly optimized |
|
II just expanded the function. How it is handled RN in the calling scriptblock was not adjusted at 11PM. I am aware of ongoing discussion about that $appIds.Data thread.
BR
AD
…________________________________
From: Nick Brown ***@***.***>
Sent: 15 March 2024 10:42
To: Romanitho/Winget-AutoUpdate ***@***.***>
Cc: Andrzej Demski ***@***.***>; Comment ***@***.***>
Subject: Re: [Romanitho/Winget-AutoUpdate] Fix for Group Policy enforced include/exclude lists not being imported corrected (PR #580)
Added the uri fetching. It does seem odd you are creating custom objects (key value pair) then ignoring those in the main code base, question if that is needed or you just need an array of the items, which is what I'm doing.
I'm mainly focused on the excluded apps section, as the original code wasn't fully working. New code does seem happy though it can always be slightly optimized
—
Reply to this email directly, view it on GitHub<#580 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASAJCPT7I6GYDOT4YEFADN3YYK677AVCNFSM6AAAAABEJJRW26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGI4DGOJVG4>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix for Group Policy enforced include/exclude lists not being imported corrected.
Previously the GPO allow/block list wasn't getting imported correctly, (empty array), this fixes that by using native powershell registry calls