Update Get-IncludedApps.ps1 #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded logic to allow pulling Whitelist from URI
AndrewDemski-ad-gmail-com
temporarily deployed
to
megalinter
GitHub Actions
Inactive
nickjisc
added a commit
to nickjisc/Winget-AutoUpdate
that referenced
this pull request
Mar 15, 2024
|
I'll finish integration with calling script blocks after weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded logic to allow pulling Whitelist from URI
Proposed Changes
It was recently brought to our attention that the Get-IncludedApps.ps1 file could provide a whitelist with package IDs from the registry and a locally stored text file, but when the same file was placed in e.g. a text file in the cloud (e.g. "Azure", we were... unable to get it…
To make our life easier, I decided to define a base class that defines the return object for all supported scenarios.
(If you find this necessary, I'm open to suggestions on where to move it.)
Related Issues
Inspired by #579 I decided to perform a quick test and with correctly configured Azure Storage Container I was able to safely retrieve the same file which I uploaded from local folder.
To make it usable for this test we will need to define another switch "$URIList" which will utilize new section of 'Get-IncludedApps' function.