Cover generators with tests #65

KonstantinLapkovsky · 2023-12-15T18:17:57Z

Issue #49

tests/fixtures/ControllerGeneratorTest/api.php

tests/Support/Controller/ControllerMockTrait.php

tests/Support/NovaTest/NovaTestMockTrait.php

tests/Support/Shared/GeneratorMockTrait.php

DenTray · 2023-12-26T05:16:37Z

@KonstantinLapkovsky please check all other mock traits according my comments

# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php

DenTray · 2024-01-22T00:08:00Z

tests/Support/Shared/GeneratorMockTrait.php

+        return $this->mockNativeFunction('\\RonasIT\\Support\\Generators', 'class_exists', $result);
+    }
+
+    public function mockCheckingNonExistentNovaPackageExistence(): Mock


Suggested change

public function mockCheckingNonExistentNovaPackageExistence(): Mock

public function mockCheckingNovaPackageExistence(bool $result = false): Mock

DenTray · 2024-01-22T00:13:24Z

tests/Support/Controller/ControllerMockTrait.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace RonasIT\Support\Tests\Support\Controller;


Suggested change

namespace RonasIT\Support\Tests\Support\Controller;

namespace RonasIT\Support\Tests\Support\ControllerGeneratorTest;

DenTray · 2024-01-22T00:13:46Z

tests/Support/Shared/GeneratorMockTrait.php

@@ -0,0 +1,66 @@
+<?php
+
+namespace RonasIT\Support\Tests\Support\Shared;


Suggested change

namespace RonasIT\Support\Tests\Support\Shared;

namespace RonasIT\Support\Tests\Support;

DenTray · 2024-01-22T00:23:40Z

tests/Support/NovaResource/NovaResourceMockTrait.php

@@ -0,0 +1,74 @@
+<?php
+
+namespace RonasIT\Support\Tests\Support\NovaResource;


Suggested change

namespace RonasIT\Support\Tests\Support\NovaResource;

namespace RonasIT\Support\Tests\Support\NovaResourceGeneratorTest;

DenTray · 2024-01-22T00:26:08Z

tests/Support/NovaTest/NovaTestMockTrait.php

@@ -0,0 +1,126 @@
+<?php
+
+namespace RonasIT\Support\Tests\Support\NovaTest;


Suggested change

namespace RonasIT\Support\Tests\Support\NovaTest;

namespace RonasIT\Support\Tests\Support\NovaTestGeneratorTest;

DenTray · 2024-01-22T00:41:35Z

tests/Support/Shared/GeneratorMockTrait.php

+        return $this->mockClassExistsFunction(false);
+    }
+
+    public function classExistsMethodCall(?string $path, ?string $className, bool $result = true): array


It looks like optional args are using only in the mockResourceGeneratorForNonExistingNovaResource method. Could we use filled args there and remove optional here?

DenTray · 2024-01-25T10:12:25Z

tests/ControllerGeneratorTest.php

+        $this->removeRecursivelyGeneratedFolders(getcwd() . '/tests/vfs:');
+    }
+
+    protected function removeRecursivelyGeneratedFolders(string $path): void


let's move it to the parent class, but before please try to mock mk_dir_recursive function, as we discussed, it may be helpfull and able you to remove this logic at all

DenTray · 2024-01-25T10:16:03Z

tests/ControllerGeneratorTest.php

+        $this->removeRecursivelyGeneratedFolders(getcwd() . '/vfs:');
+        $this->removeRecursivelyGeneratedFolders(getcwd() . '/tests/vfs:');


could we implement clearVFS and remove all available paths inside?

DenTray · 2024-01-25T10:20:02Z

tests/NovaResourceGeneratorTest.php

+        $this->assertEquals($this->getDatabaseAssertionData(), $fields);
+    }
+
+    public function getFieldsMock(): array


let's move it to the fixture

DenTray · 2024-01-25T10:20:22Z

tests/NovaResourceGeneratorTest.php

+        ];
+    }
+
+    public function getDatabaseAssertionData(): array


let's use such array inside the test cases without additional method

DenTray · 2024-01-25T10:45:30Z

tests/Support/ControllerGeneratorTest/ControllerGeneratorMockTrait.php

+    public function mockControllerGeneratorForExistingController(): void
+    {
+        $this->mockClass(ControllerGenerator::class, [
+            $this->classExistsMethodCall('controllers', 'PostController')
+        ]);
+    }
+
+    public function mockControllerGeneratorForNotExistingService(): void
+    {
+        $this->mockClass(ControllerGenerator::class, [
+            $this->classExistsMethodCall('controllers', 'PostController', false),
+            $this->classExistsMethodCall('services', 'PostService', false)
+        ]);
+    }


as discussed, let's remove this methods and call such logic inside the tests

DenTray · 2024-01-25T10:55:19Z

tests/Support/ControllerGeneratorTest/ControllerGeneratorMockTrait.php

+        ]);
+    }
+
+    public function mockConfigurations(): void


it seems we no need in this, let's try to define getPackageProviders method inside the base test case

DenTray · 2024-01-25T11:32:48Z

tests/Support/GeneratorMockTrait.php

+
+trait GeneratorMockTrait
+{
+    public function mockNativeFunction(string $namespace, string $name, $result): Mock


please check that such logic already exists in the laravel helpers package and use it

Konstantin Lapkovsky added 6 commits December 15, 2023 13:40

chore: remove redundant logic.

8f76f20

test: add Nova test generator test case.

aaf4e67

test: separate tests for Nova Resources and Nova tests.

76dba4c

Merge branch '42-extend-nova-resource-generator' into 49-add-tests

1605125

test: add tests for Nova Resource.

dfb9d07

test: add fixture.

ac6845c

KonstantinLapkovsky requested a review from DenTray December 15, 2023 18:17

KonstantinLapkovsky self-assigned this Dec 15, 2023

test: add tests for controller generator.

c20b26f

KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests December 18, 2023 08:02

KonstantinLapkovsky assigned DenTray and unassigned KonstantinLapkovsky Dec 20, 2023

Merge branch 'master' into 49-add-tests

fa2c9f7

KonstantinLapkovsky changed the base branch from 49-cover-entity-generator-with-tests to master December 20, 2023 08:11

KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests December 20, 2023 08:11

chore: remove useless methods.

5fa7683

DenTray requested changes Dec 26, 2023

View reviewed changes

tests/fixtures/ControllerGeneratorTest/api.php Show resolved Hide resolved

tests/Support/Controller/ControllerMockTrait.php Outdated Show resolved Hide resolved

tests/Support/NovaTest/NovaTestMockTrait.php Outdated Show resolved Hide resolved

DenTray requested changes Dec 26, 2023

View reviewed changes

tests/Support/Shared/GeneratorMockTrait.php Outdated Show resolved Hide resolved

DenTray assigned KonstantinLapkovsky and unassigned DenTray Dec 26, 2023

Konstantin Lapkovsky added 3 commits January 18, 2024 14:39

test: correct test functions.

0443851

Merge branch 'master' into 49-add-tests

2933b28

# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php

test: correct tests.

193ab1b

KonstantinLapkovsky assigned DenTray and unassigned KonstantinLapkovsky Jan 18, 2024

KonstantinLapkovsky changed the base branch from 49-cover-entity-generator-with-tests to master January 18, 2024 13:02

KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests January 18, 2024 13:02

DenTray requested changes Jan 22, 2024

View reviewed changes

DenTray assigned KonstantinLapkovsky Jan 22, 2024

DenTray removed their assignment Jan 22, 2024

KonstantinLapkovsky changed the base branch from 49-cover-entity-generator-with-tests to master January 25, 2024 09:30

Konstantin Lapkovsky added 2 commits January 25, 2024 13:43

chore: correct tests.

b3916c3

chore: remove redundant logic.

543abdf

KonstantinLapkovsky requested a review from DenTray January 25, 2024 09:52

KonstantinLapkovsky assigned DenTray and unassigned KonstantinLapkovsky Jan 25, 2024

DenTray requested changes Jan 25, 2024

View reviewed changes

Konstantin Lapkovsky added 3 commits January 25, 2024 19:43

chore: rewrite test logic.

b4204ff

test: correct test mocks.

187cdc4

test: correct fixture path extracting.

747fc31

KonstantinLapkovsky requested a review from DenTray February 2, 2024 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cover generators with tests #65

Cover generators with tests #65

KonstantinLapkovsky commented Dec 15, 2023

DenTray commented Dec 26, 2023

DenTray Jan 22, 2024

DenTray Jan 22, 2024

DenTray Jan 22, 2024

DenTray Jan 22, 2024

DenTray Jan 22, 2024

DenTray Jan 22, 2024

DenTray Jan 25, 2024

DenTray Jan 25, 2024

DenTray Jan 25, 2024

DenTray Jan 25, 2024

DenTray Jan 25, 2024

DenTray Jan 25, 2024

DenTray Jan 25, 2024

	public function mockCheckingNonExistentNovaPackageExistence(): Mock
	public function mockCheckingNovaPackageExistence(bool $result = false): Mock

		@@ -0,0 +1,75 @@
		<?php

		namespace RonasIT\Support\Tests\Support\Controller;

		@@ -0,0 +1,66 @@
		<?php

		namespace RonasIT\Support\Tests\Support\Shared;

	namespace RonasIT\Support\Tests\Support\Shared;
	namespace RonasIT\Support\Tests\Support;

		@@ -0,0 +1,74 @@
		<?php

		namespace RonasIT\Support\Tests\Support\NovaResource;

		@@ -0,0 +1,126 @@
		<?php

		namespace RonasIT\Support\Tests\Support\NovaTest;

		$this->removeRecursivelyGeneratedFolders(getcwd() . '/vfs:');
		$this->removeRecursivelyGeneratedFolders(getcwd() . '/tests/vfs:');

Cover generators with tests #65

Are you sure you want to change the base?

Cover generators with tests #65

Conversation

KonstantinLapkovsky commented Dec 15, 2023

DenTray commented Dec 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment