Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to merge docs #45

Closed
DenTray opened this issue May 3, 2022 · 13 comments · Fixed by #108
Closed

Ability to merge docs #45

DenTray opened this issue May 3, 2022 · 13 comments · Fixed by #108
Assignees
@Goodmain
Labels
state: ready to version type: enhancement
Milestone
2.2

Comments

@DenTray
Copy link
Collaborator

DenTray commented May 3, 2022

Ability to set additional swagger docs in the config file to show it.

Will be helpful for using packages which provides endpoints.
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
feat: ability to merge docs;
fe4ffe6 
Refs: #45
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
feat: ability to merge docs;
4aacb52 
Refs: #45
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
feat: ability to merge docs;
6438c1f 
Refs: #45
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
feat: ability to merge docs;
edf14e3 
Refs: #45
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
chore: renaming method;
257107d 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 6, 2022
@pirs1337
feat: ability to merge docs;
83f6e51 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 6, 2022
@pirs1337
feat: ability to merge docs;
3836a7b 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 7, 2022
@pirs1337
feat: ability to merge docs;
6c0e1cf 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 7, 2022
@pirs1337
feat: ability to merge docs;
5405dba 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 13, 2022
@pirs1337
feat: ability to merge docs;
b5b226f 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 13, 2022
@pirs1337
feat: ability to merge docs;
55bf252 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 13, 2022
@pirs1337
feat: ability to merge docs;
d680502 
Refs: #45
pirs1337 added a commit that referenced this issue Aug 19, 2022
@pirs1337
feat: removing stdClass from swagger interface;
80cbd2f 
Refs: #45
pirs1337 added a commit that referenced this issue Sep 15, 2022
@pirs1337
feat: rename rulesOfTypes property to ruleToTypeMap
d32428e 
Refs: #45
pirs1337 added a commit that referenced this issue Sep 15, 2022
@pirs1337
feat: move fileContent paths to separate variable
5257cec 
Refs: #45
DenTray added a commit that referenced this issue Sep 19, 2022
@DenTray
Merge pull request #55 from RonasIT/45_ability_to_merge_docs
c2ae22e 
#45:- ability to merge docs
@pirs1337 pirs1337 assigned DenTray and pirs1337 and unassigned pirs1337, alinoksha and DenTray Oct 31, 2022
pirs1337 added a commit that referenced this issue Oct 31, 2022
@pirs1337
fix: fix show of type when rule is int
1281155 
Refs: #45
DenTray added a commit that referenced this issue Nov 2, 2022
@DenTray
Merge pull request #65 from RonasIT/45_ability_to_merge_docs
d9ff2e2 
#45:- fix: fix showing of type when rule is int
@DenTray DenTray assigned DenTray and unassigned pirs1337 Nov 3, 2022
@NikitaYakovlev
Copy link

@DenTray work as expected:

image

@DenTray
Copy link
Collaborator Author

DenTray commented Mar 28, 2023 •
edited
Loading

I've found a one bug, the documentation view will be broken if we set invalid file name inside the additional_paths config

image

image

@vitgrams could you please fix it?

@DenTray DenTray assigned vitgrams and unassigned DenTray Mar 28, 2023
DenTray added a commit that referenced this issue Mar 30, 2023
@DenTray
Merge pull request #81 from RonasIT/45_fix_exception_when_setting_inv…
c9efdfb 
…alid_additional_path

#45: Check file existence when parsing additional doc files
@DenTray
Copy link
Collaborator Author

DenTray commented Mar 30, 2023

@vitgrams please also fix next cases:

  • set non json file as additional doc
  • set non open api json file

@DenTray DenTray added this to the 2.2 milestone Jun 20, 2023
@DenTray DenTray assigned Goodmain and unassigned vitgrams Sep 25, 2023
@DenTray
Copy link
Collaborator Author

DenTray commented Sep 25, 2023

@Goodmain please proceed with this one, we already has #82 for it

DenTray added a commit that referenced this issue Oct 2, 2023
@DenTray
Merge pull request #82 from RonasIT/45_fix_exception_when_setting_inv…
f45a57d 
…alid_additional_path

#45: Add swagger spec validator to validate temp and additional doc format
@Goodmain
Copy link
Contributor

Goodmain commented Oct 2, 2023

@DenTray Done and merged

@Goodmain Goodmain assigned DenTray and unassigned Goodmain Oct 2, 2023
@DenTray
Copy link
Collaborator Author

DenTray commented Oct 16, 2023

@Goodmain I've tested and found few enhancements:

  1. Let's also report empty file and not exists file cases as exceptions
  2. Let's add reference to validatable file to the exception

@DenTray DenTray assigned Goodmain and unassigned DenTray Oct 16, 2023
@Goodmain Goodmain mentioned this issue Oct 23, 2023
Merged
7 tasks
@DenTray DenTray reopened this Oct 23, 2023
@DenTray
Copy link
Collaborator Author

DenTray commented Oct 23, 2023

@Goodmain exceptions works fine, but it fail documentation view now, could you please catch and report such exceptions as it works with the OpenAPIValidator Spec?

Goodmain added a commit that referenced this issue Oct 26, 2023
@Goodmain
feat: catch and report exception during Open-Api file validation (#45)
654e3f3
DenTray added a commit that referenced this issue Oct 27, 2023
@DenTray
Merge pull request #109 from RonasIT/45-catch-exceptions-about-empty-…
1ce8737 
…or-not-exist-file

feat: catch and report exception during Open-Api file validation (#45)
@DenTray
Copy link
Collaborator Author

DenTray commented Oct 27, 2023

@Goodmain works well now, thanks!

@DenTray
Copy link
Collaborator Author

DenTray commented Nov 7, 2023

Released in 2.2 version

@DenTray DenTray closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Goodmain Goodmain

Labels
state: ready to version type: enhancement
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Throw exception for empty or not exists files RonasIT/laravel-swagger
6 participants
@Goodmain @DenTray @NikitaYakovlev @alinoksha @pirs1337 @vitgrams