Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evikulov/readme update #63

Merged
merged 26 commits into from
Sep 27, 2022
Merged

Evikulov/readme update #63

merged 26 commits into from
Sep 27, 2022

Conversation

EVikulov
Copy link
Contributor

@EVikulov EVikulov commented Sep 7, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
EVikulov and others added 10 commits September 7, 2022 14:58
Co-authored-by: Alexander Storozhevsky <astorozhevsky@ronasit.com>
Co-authored-by: Alexander Storozhevsky <astorozhevsky@ronasit.com>
Co-authored-by: Alexander Storozhevsky <astorozhevsky@ronasit.com>
Co-authored-by: Alexander Storozhevsky <astorozhevsky@ronasit.com>
Co-authored-by: Alexander Storozhevsky <astorozhevsky@ronasit.com>
@DenTray
Copy link
Collaborator

DenTray commented Sep 8, 2022

@EVikulov could you please rewrite the "Installation" block:

  1. Remove Composer/Laravel/Plugin headings
  2. Text about the Laravel 5.5. version should be decorated as Note
  3. The second point in the current Laravel heading should be simplified to Run php artisan vendor:publish
  4. Hightlight all class-related words (naespaces, classes, etc.) as a code (e.g. Http/Kernel.php)
  5. In the second point in the current Plugin heading please rewrite "Use" word to "Add"
  6. The third point in the current Plugin heading should be removed
  7. Rewrite the current sentence to "Add the following env variables"
  8. Remove fourth point about the env variables
  9. Hightlight "Please note that this way will be removed after updating PHPUnit up to 10 version (Event System for extending PHPUnit sebastianbergmann/phpunit#4676)" as a note
  10. Rewrite the description annotation in the request class example
  11. Rewrite the field annotation from the @some_field to the real field from the class (@is_active)

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@DenTray DenTray assigned EVikulov and unassigned astorozhevsky Sep 8, 2022
readme.md Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
astorozhevsky and others added 7 commits September 27, 2022 17:49
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
refs: #63

Co-authored-by: DenTray <dpankratov@ronasit.com>
@astorozhevsky astorozhevsky merged commit 9db0443 into master Sep 27, 2022
@DenTray DenTray deleted the evikulov/readme-update branch September 18, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants