feat: removed unnecessary grouping by prefix #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
DenTray
requested changes
Jul 6, 2023
| @@ -0,0 +1,117 @@ | |||
| { | |||
| "swagger": "2.0", | |||
Comment on lines
+569
to
+571
| $tag = (!empty($globalPrefix) && "/{$explodedUri[1]}" === $globalPrefix) | ||
| ? Arr::get($explodedUri, 2) | ||
| : Arr::get($explodedUri, 1); |
There was a problem hiding this comment.
please to implement something like this
Suggested change
| $tag = (!empty($globalPrefix) && "/{$explodedUri[1]}" === $globalPrefix) | |
| ? Arr::get($explodedUri, 2) | |
| : Arr::get($explodedUri, 1); | |
| $tag = array_shift($explodedUri); | |
| if ($globalPrefix === $tag)) { | |
| $tag = array_shift($explodedUri); | |
| } |
|
|
||
| $service->addData($request, $response); | ||
| } | ||
|
|
There was a problem hiding this comment.
please implement test case for global prefix equals /global and we call api /global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #90 (issue)
Type of change
Bug fix (non-breaking change which fixes an issue)