Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RK-19885 - Upgrade electron-builder and updater #363

Merged
merged 2 commits into from
Oct 3, 2023
Merged

RK-19885 - Upgrade electron-builder and updater #363

merged 2 commits into from
Oct 3, 2023

Conversation

Urook
Copy link
Contributor

@Urook Urook commented Oct 2, 2023 •
edited
Loading

Upgrade electron-builder and electron-updater
Removed patch because:

  • It was created in RK-6154 patch for windows signature verification #167 to address this
  • It looks like the vulnerability was fixed by them around version 5.0.0 via adding reject function to handleError and throwing/rejecting on stderr (as well as rejecting/throwing an error in a certain catch clause)

@Urook Urook force-pushed the update-electron-updater-builder branch from 2eac972 to a827b1c Compare October 2, 2023 22:00
@Urook Urook requested review from dan505512 and a team October 3, 2023 06:17
@Urook
Copy link
Contributor Author

Urook commented Oct 3, 2023 •
edited by jira bot
Loading

Github Enforcer opened Task: RK-19885

@sonariorobot sonariorobot changed the title Upgrade electron-builder and updater RK-19885 - Upgrade electron-builder and updater Oct 3, 2023
@Urook
Copy link
Contributor Author

Urook commented Oct 3, 2023

@dan505512 Are there any tests you want me to run before merging?

@dan505512
Copy link
Contributor

We can't get anything to build at the moment so I don't think we need to. Once we get the artifacts in a draft release we'll test @Urook

@sonariorobot sonariorobot merged commit 5051bd4 into master Oct 3, 2023
7 checks passed
@sonariorobot sonariorobot deleted the update-electron-updater-builder branch October 3, 2023 06:25
@Urook
Copy link
Contributor Author

Urook commented Oct 3, 2023

@dan505512 Cool.
Who knows, maybe this will even fix the auto update errors we constantly have, the prev version is ~3 years old

@dan505512
Copy link
Contributor

@dan505512 Cool.
Who knows, maybe this will even fix the auto update errors we constantly have, the prev version is ~3 years old

בעז"ה

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan505512 dan505512 dan505512 approved these changes

Assignees
No one assigned
Labels
DeployEnforcer/MergeOnceApproved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Urook @dan505512 @sonariorobot