Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: job employer #152

Open
TorchedSammy opened this issue May 10, 2022 · 3 comments
Open

feat: job employer #152

TorchedSammy opened this issue May 10, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@TorchedSammy
Copy link
Member

this would just be a specific handler for interactive jobs. it'll start new jobs and do whatever with them

use would be overwriting the hilbish.job.employer function
@TorchedSammy TorchedSammy added the enhancement New feature or request label May 10, 2022
TorchedSammy added a commit that referenced this issue May 13, 2022
@TorchedSammy
feat: add hilbish.job.add function
827c25f 
this is mainly to accomodate for the employer
handler (#152)
@TorchedSammy TorchedSammy mentioned this issue May 13, 2022
Merged
4 tasks
@TorchedSammy
Copy link
Member Author

i don't think this function/handler in specific will provide any practical use, #154 is kinda similar to the initial idea i had but actually makes sense

@TorchedSammy TorchedSammy closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2022
TorchedSammy added a commit that referenced this issue May 22, 2022
@TorchedSammy
feat: job enhancements (#153)
d2f16df 
* feat: add hilbish.job.add function

this is mainly to accomodate for the employer
handler (#152)

* feat!: add start function to jobs

the commit itself adds a few things but the
main purpose is to facilitate a lua side start
function that can restart the job

there is a breaking change in the hilbish.job.add
function; it is now required to provide an extra
table for arguments, since the first cmd
table isnt really what's actually ran

* fix: reuse standard files for jobs

* fix: deadlock in lua job add function and not taking proper amount of args

* fix: assign binary path to job

* feat: emit job.add hook when job is added

* chore: update modules

* fix: use setpgid on cmd procattr for background jobs

* fix: use right procattr on correct os

* fix: set bg proc attr in build tagged file

* feat: add disown function

* fix: stop jobs on exit

* feat: add disown command

* feat: add jobs.last function to get last job

* feat: make disown command get last job if id isnt suppied as arg

* chore: remove unused code

* feat: add job output

* chore: fix comments

* fix!: make exec path in job add explicit in lua side

* docs: add docs and changelogs relating to jobs
@TorchedSammy
Copy link
Member Author

this should maybe be revisited to allow a custom job handler when using an alternative runner mode

@TorchedSammy TorchedSammy reopened this Aug 9, 2022
@TorchedSammy TorchedSammy added this to the v2.0 (Hibiscus) milestone Aug 9, 2022
@TorchedSammy
Copy link
Member Author

this would be more involved that just adding a single handler to spawn jobs, so ill revisit and it wont be in 2.0

@TorchedSammy TorchedSammy removed this from the v2.0 (Hibiscus) milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TorchedSammy