Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the API calls /evidencePath and /geneCount still needed? #631

Closed
marco-brandizi opened this issue Apr 6, 2022 · 3 comments
Closed
Assignees
Labels
project:web service Knetminer web service (ws), including search, JSON out, data export, config reading. question

Comments

@marco-brandizi
Copy link
Member

marco-brandizi commented Apr 6, 2022

/evidencePath

From the Js comments, it looks like this was used in the evidence table to go to a network view about the genes and paths associated to a given evidence concept (ie, hit by search string and related to genes).

It appears that the KnetMiner application doesn't use this anymore, the question here is: do we have clients around that rely on this call, or can we remove it from the codebase?

/geneCount

Same question, is this still in use? No trace in the .js. The code consider only a gene list as input, then it uses it to compute a network view and finally returns some counts from the resulting subgraph.

@marco-brandizi marco-brandizi added project:web service Knetminer web service (ws), including search, JSON out, data export, config reading. question labels Apr 6, 2022
@marco-brandizi marco-brandizi changed the title is the API call /evidencePath still needed? Are the API calls /evidencePath and /geneCount still needed? Apr 6, 2022
@KeywanHP
Copy link
Member

KeywanHP commented Apr 6, 2022

It's not used by us or others. It gets ondexIds and does shortest paths plus some filtering. Can be removed if the code is not useful.

@marco-brandizi
Copy link
Member Author

Thanks @KeywanHP. What about /geneCount? KnetMiner client has no call for it.

@KeywanHP
Copy link
Member

KeywanHP commented Apr 6, 2022

Same for /geneCount - should be safe to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:web service Knetminer web service (ws), including search, JSON out, data export, config reading. question
Projects
None yet
Development

No branches or pull requests

2 participants